From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: linux-efi <linux-efi@vger.kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Alexander Graf <agraf@suse.de>,
Matt Fleming <matt@codeblueprint.co.uk>
Subject: Re: [PATCH v1] efi/earlycon: Remap entire framebuffer after page initialization
Date: Tue, 12 Nov 2019 14:59:20 +0200 [thread overview]
Message-ID: <20191112125920.GT32742@smile.fi.intel.com> (raw)
In-Reply-To: <20191112125754.GS32742@smile.fi.intel.com>
On Tue, Nov 12, 2019 at 02:57:54PM +0200, Andy Shevchenko wrote:
> On Mon, Nov 11, 2019 at 05:59:42PM +0000, Ard Biesheuvel wrote:
> > On Mon, 11 Nov 2019 at 15:44, Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > When the commit 69c1f396f25b ("efi/x86: Convert x86 EFI earlyprintk
> > > into generic earlycon implementation") moved x86 specific EFI earlyprintk
> > > implementation to shared location it also tweaked the behaviour. In particular
> > > it dropped a trick with full framebuffer remapping after page initialization.
> > > This lead to two regressions:
> > > 1) very slow scrolling after page initialization;
> > > 2) kernel hang when keep_bootcon parameter is being provided.
> > >
> > > Returning the trick back fixes #2 and mitigates, i.e. reduces the window when
> > > slowness appears, #1 presumably due to eliminating heavy map()/unmap()
> > > operations per each pixel line on the screen.
>
> > Thanks for fixing this. One question below.
> >
> > > +static __init int early_efi_map_fb(void)
> > > +{
> > > + u32 size;
> > > +
> > > + size = screen_info.lfb_size;
> > > + if (pgprot_val(fb_prot) == pgprot_val(PAGE_KERNEL))
> > > + efi_fb = memremap(fb_base, size, MEMREMAP_WB);
> > > + else
> > > + efi_fb = memremap(fb_base, size, MEMREMAP_WC);
> > > +
> > > + return efi_fb ? 0 : -ENOMEM;
> > > +}
> > > +early_initcall(early_efi_map_fb);
> > > +
> > > +static __exit void early_efi_unmap_fb(void)
> >
> > Will there be a user for this routine? If not, can we just drop it?
>
> The same question can be applied to the driver core part(s), e.g.
> deferred_probe_exit() in dd.c).
I noted that I missed __exitcall() here. But will wait for your answer.
> The above basically what Greg KH told people to do. While it is partially cargo
> cult here I can imagine that in some environments (virtual or kexec) somebody
> would like to get a picture of (post-mortem?) analysis where it would be
> helpful. Also code looks symmetrical in order to resource management. So, if
> you insist, I'll remove it, although I personally like my variant.
>
> > > +{
> > > + memunmap(efi_fb);
> > > +}
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-11-12 12:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 15:44 [PATCH v1] efi/earlycon: Remap entire framebuffer after page initialization Andy Shevchenko
2019-11-11 17:59 ` Ard Biesheuvel
2019-11-12 12:57 ` Andy Shevchenko
2019-11-12 12:59 ` Andy Shevchenko [this message]
2019-11-12 13:31 ` Ard Biesheuvel
2019-11-12 16:13 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112125920.GT32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=agraf@suse.de \
--cc=ard.biesheuvel@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox