From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C28F4C43331 for ; Tue, 12 Nov 2019 16:13:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9682C2196E for ; Tue, 12 Nov 2019 16:13:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726896AbfKLQNX (ORCPT ); Tue, 12 Nov 2019 11:13:23 -0500 Received: from mga01.intel.com ([192.55.52.88]:59626 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726008AbfKLQNX (ORCPT ); Tue, 12 Nov 2019 11:13:23 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Nov 2019 08:13:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,297,1569308400"; d="scan'208";a="229440427" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga004.fm.intel.com with ESMTP; 12 Nov 2019 08:13:21 -0800 Received: from andy by smile with local (Exim 4.93-RC1) (envelope-from ) id 1iUYnA-0003wY-DX; Tue, 12 Nov 2019 18:13:20 +0200 Date: Tue, 12 Nov 2019 18:13:20 +0200 From: Andy Shevchenko To: Ard Biesheuvel Cc: linux-efi , Mika Westerberg , Alexander Graf , Matt Fleming Subject: Re: [PATCH v1] efi/earlycon: Remap entire framebuffer after page initialization Message-ID: <20191112161320.GW32742@smile.fi.intel.com> References: <20191111154413.1505-1-andriy.shevchenko@linux.intel.com> <20191112125754.GS32742@smile.fi.intel.com> <20191112125920.GT32742@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Tue, Nov 12, 2019 at 01:31:11PM +0000, Ard Biesheuvel wrote: > On Tue, 12 Nov 2019 at 12:59, Andy Shevchenko > wrote: > > On Tue, Nov 12, 2019 at 02:57:54PM +0200, Andy Shevchenko wrote: > > > On Mon, Nov 11, 2019 at 05:59:42PM +0000, Ard Biesheuvel wrote: > > > > On Mon, 11 Nov 2019 at 15:44, Andy Shevchenko > > > > wrote: > > > > Will there be a user for this routine? If not, can we just drop it? > > > > > > The same question can be applied to the driver core part(s), e.g. > > > deferred_probe_exit() in dd.c). > > > > I noted that I missed __exitcall() here. But will wait for your answer. > > > > Ah ok, then it makes sense. Mind respinning with that added? Done! > > > The above basically what Greg KH told people to do. While it is partially cargo > > > cult here I can imagine that in some environments (virtual or kexec) somebody > > > would like to get a picture of (post-mortem?) analysis where it would be > > > helpful. Also code looks symmetrical in order to resource management. So, if > > > you insist, I'll remove it, although I personally like my variant. -- With Best Regards, Andy Shevchenko