Re: [PATCH] efi/earlycon: Fix write-combine mapping on x86

Ard Biesheuvel
2019-12-12T16:57:58Z

On Thu, 12 Dec 2019 at 17:56, Arvind Sankar <nivedita@alum.mit.edu> wrote:
>
> On Wed, Dec 11, 2019 at 10:00:07PM +0200, Andy Shevchenko wrote:
> > On Wed, Dec 11, 2019 at 06:06:28PM +0000, Ard Biesheuvel wrote:
> > > On Wed, 11 Dec 2019 at 19:03, Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > On Wed, Dec 11, 2019 at 12:37:46PM -0500, Arvind Sankar wrote:
> >
> > > > Perhaps comment near to if can explain this.
> >
> > > I'm fine with the ternary, actually. What do you feel is wrong with it?
> >
> > I don't like ternary when it takes more than one line. I found them hard to
> > follow.
> >
> > It's anyway style, so, go ahead with it.
> >
> > --
> > With Best Regards,
> > Andy Shevchenko
> >
> >
> Thanks.
> > > Can't we just set a global flag to MEMREMAP_WB or MEMREMAP_WC in the
> > > init code, and use that directly?
> > We can't use it directly in efi_earlycon_map though, so we still need to
> > translate there, and we'd need an if/else in the init code, so this
> > would just move the if/else from here to the init code.
>
> Ard, re your comment, does that cover it and the patch is ok as it
> stands then?

Yes.

I have queued it up and will send it out shortly.