From: Arvind Sankar <nivedita@alum.mit.edu>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Arvind Sankar <nivedita@alum.mit.edu>,
Ard Biesheuvel <ardb@kernel.org>,
linux-efi <linux-efi@vger.kernel.org>
Subject: Re: [PATCH] efi/earlycon: Fix write-combine mapping on x86
Date: Thu, 12 Dec 2019 11:56:50 -0500 [thread overview]
Message-ID: <20191212165649.GA117958@rani.riverdale.lan> (raw)
In-Reply-To: <20191211200007.GB32742@smile.fi.intel.com>
On Wed, Dec 11, 2019 at 10:00:07PM +0200, Andy Shevchenko wrote:
> On Wed, Dec 11, 2019 at 06:06:28PM +0000, Ard Biesheuvel wrote:
> > On Wed, 11 Dec 2019 at 19:03, Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > > On Wed, Dec 11, 2019 at 12:37:46PM -0500, Arvind Sankar wrote:
>
> > > Perhaps comment near to if can explain this.
>
> > I'm fine with the ternary, actually. What do you feel is wrong with it?
>
> I don't like ternary when it takes more than one line. I found them hard to
> follow.
>
> It's anyway style, so, go ahead with it.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
Thanks.
> > Can't we just set a global flag to MEMREMAP_WB or MEMREMAP_WC in the
> > init code, and use that directly?
> We can't use it directly in efi_earlycon_map though, so we still need to
> translate there, and we'd need an if/else in the init code, so this
> would just move the if/else from here to the init code.
Ard, re your comment, does that cover it and the patch is ok as it
stands then?
next prev parent reply other threads:[~2019-12-12 16:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 23:24 [PATCH] efi/earlycon: Fix write-combine mapping on x86 Arvind Sankar
2019-12-11 8:22 ` Ard Biesheuvel
2019-12-11 11:04 ` Andy Shevchenko
2019-12-11 14:00 ` Ard Biesheuvel
2019-12-11 15:50 ` Arvind Sankar
2019-12-11 17:37 ` Arvind Sankar
2019-12-11 18:03 ` Andy Shevchenko
2019-12-11 18:06 ` Ard Biesheuvel
2019-12-11 20:00 ` Andy Shevchenko
2019-12-12 16:56 ` Arvind Sankar [this message]
2019-12-12 16:57 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212165649.GA117958@rani.riverdale.lan \
--to=nivedita@alum.mit.edu \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ard.biesheuvel@linaro.org \
--cc=ardb@kernel.org \
--cc=linux-efi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox