From: Dan Carpenter <dan.carpenter@oracle.com>
To: Arvind Sankar <nivedita@alum.mit.edu>
Cc: kbuild@lists.01.org, lkp@intel.com, kbuild-all@lists.01.org,
linux-efi@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [efi:next 39/40] drivers/firmware/efi/libstub/efi-stub-helper.c:265 efi_convert_cmdline() warn: qualifier 'l' ignored for %s specifier
Date: Wed, 20 May 2020 21:20:22 +0300 [thread overview]
Message-ID: <20200520182022.GS3041@kadam> (raw)
In-Reply-To: <20200520180008.GA3428271@rani.riverdale.lan>
On Wed, May 20, 2020 at 02:00:08PM -0400, Arvind Sankar wrote:
> On Wed, May 20, 2020 at 08:54:49PM +0300, Dan Carpenter wrote:
> > On Wed, May 20, 2020 at 11:43:08AM -0400, Arvind Sankar wrote:
> > > On Wed, May 20, 2020 at 05:09:03PM +0300, Dan Carpenter wrote:
> > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git next
> > > > head: e5fbadd1179cdadeaa44d71a9ec068c5bc100524
> > > > commit: 85f5afd4322d294a7eca0d304744a1646113fbd9 [39/40] efi/libstub: Use snprintf with %ls to convert the command line
> > > > config: x86_64-defconfig (attached as .config)
> > > >
> > > > If you fix the issue, kindly add following tag as appropriate
> > > > Reported-by: kbuild test robot <lkp@intel.com>
> > > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > > >
> > > > New smatch warnings:
> > > > drivers/firmware/efi/libstub/efi-stub-helper.c:265 efi_convert_cmdline() warn: qualifier 'l' ignored for %s specifier
> > > >
> > > > # https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git/commit/?id=85f5afd4322d294a7eca0d304744a1646113fbd9
> > > > git remote add efi https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git
> > > > git remote update efi
> > > > git checkout 85f5afd4322d294a7eca0d304744a1646113fbd9
> > > > vim +/l +265 drivers/firmware/efi/libstub/efi-stub-helper.c
> > > >
> > > > c625d1c203941f drivers/firmware/efi/efi-stub-helper.c H. Peter Anvin 2013-09-20 258 options_bytes++; /* NUL termination */
> > > > 9403e462fb5ffa drivers/firmware/efi/efi-stub-helper.c Leif Lindholm 2014-04-04 259
> > > > 1e45bf7372c48c drivers/firmware/efi/libstub/efi-stub-helper.c Ard Biesheuvel 2020-02-10 260 status = efi_allocate_pages(options_bytes, &cmdline_addr, max_addr);
> > > > 5fef3870c572a3 drivers/firmware/efi/efi-stub-helper.c Roy Franz 2013-09-22 261 if (status != EFI_SUCCESS)
> > > > 5fef3870c572a3 drivers/firmware/efi/efi-stub-helper.c Roy Franz 2013-09-22 262 return NULL;
> > > > 5fef3870c572a3 drivers/firmware/efi/efi-stub-helper.c Roy Franz 2013-09-22 263
> > > > 85f5afd4322d29 drivers/firmware/efi/libstub/efi-stub-helper.c Arvind Sankar 2020-05-18 264 snprintf((char *)cmdline_addr, options_bytes, "%.*ls",
> > > > ^
> > > > The "l" doesn't make sense here?
> > >
> > > The previous patches add support for wide strings to the version of
> > > snprintf used here.
> >
> > Ah. Thanks. I will update the Smatch check.
> >
> > regards,
> > dan carpenter
> >
> Note that the main kernel's printf still doesn't support it. It's only
> been added to the version in drivers/firmware/efi/libstub/vsprintf.c
> (added as part of this series).
Ah... I looked and looked at lib/vsprintf.c and wondered if I was going
mad. :P Thanks.
regards,
dan carpenter
prev parent reply other threads:[~2020-05-20 18:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 14:09 [efi:next 39/40] drivers/firmware/efi/libstub/efi-stub-helper.c:265 efi_convert_cmdline() warn: qualifier 'l' ignored for %s specifier Dan Carpenter
2020-05-20 15:43 ` Arvind Sankar
2020-05-20 17:54 ` Dan Carpenter
2020-05-20 18:00 ` Arvind Sankar
2020-05-20 18:00 ` Ard Biesheuvel
2020-05-20 18:20 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520182022.GS3041@kadam \
--to=dan.carpenter@oracle.com \
--cc=ardb@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-efi@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nivedita@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox