From: Borislav Petkov <bp@alien8.de>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-efi@vger.kernel.org, Lenny Szubowicz <lszubowi@redhat.com>,
Arvind Sankar <nivedita@alum.mit.edu>
Subject: Re: [PATCH] efi: mokvar-table: fix some issues in new code
Date: Tue, 29 Sep 2020 18:58:40 +0200 [thread overview]
Message-ID: <20200929165840.GI21110@zn.tnic> (raw)
In-Reply-To: <20200924160546.8967-1-ardb@kernel.org>
On Thu, Sep 24, 2020 at 06:05:46PM +0200, Ard Biesheuvel wrote:
> Fix a couple of issues in the new mokvar-table handling code, as
> pointed out by Arvind and Boris:
> - don't bother checking the end of the physical region against the start
> address of the mokvar table,
> - ensure that we enter the loop with err = -EINVAL,
> - replace size_t with unsigned long to appease pedantic type equality
> checks.
>
> Cc: Lenny Szubowicz <lszubowi@redhat.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Arvind Sankar <nivedita@alum.mit.edu>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> drivers/firmware/efi/mokvar-table.c | 25 +++++++++++--------------
> 1 file changed, 11 insertions(+), 14 deletions(-)
i386 allmodconfig looks good.
Tested-by: Borislav Petkov <bp@suse.de>
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-09-29 16:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 16:05 [PATCH] efi: mokvar-table: fix some issues in new code Ard Biesheuvel
2020-09-24 19:12 ` Arvind Sankar
2020-09-24 19:21 ` Lenny Szubowicz
2020-09-29 16:58 ` Borislav Petkov [this message]
2020-09-29 17:36 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929165840.GI21110@zn.tnic \
--to=bp@alien8.de \
--cc=ardb@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=lszubowi@redhat.com \
--cc=nivedita@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox