From: Leif Lindholm <leif@nuviainc.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>,
linux-efi <linux-efi@vger.kernel.org>,
grub-devel@gnu.org, Daniel Kiper <daniel.kiper@oracle.com>
Subject: Re: [PATCH 4/4] linux: ignore FDT unless we need to modify it
Date: Fri, 23 Oct 2020 14:16:04 +0100 [thread overview]
Message-ID: <20201023131604.GF1664@vanye> (raw)
In-Reply-To: <CAMj1kXFKSf0HVxLt1GdqeuErFH+r-=NxTnPV7TYjg0b-9hXj7w@mail.gmail.com>
On Fri, Oct 23, 2020 at 15:12:50 +0200, Ard Biesheuvel wrote:
> On Fri, 23 Oct 2020 at 14:47, Leif Lindholm <leif@nuviainc.com> wrote:
> >
> > On Fri, Oct 23, 2020 at 14:08:25 +0200, Ard Biesheuvel wrote:
> > > Now that we implemented supported for the LoadFile2 protocol for initrd
> > > loading, there is no longer a need to pass the initrd parameters via
> > > the device tree. This means there is no longer a reason to update the
> > > device tree in the first place, and so we can ignore it entirely.
> >
> > There is a change in behaviour here which I don't think matters, but
> > I'll call it out anyway:
> > If there was ever a kernel out there with an EFI stub that depended on
> > a chosen node existing in the DT, and the one provide by firmware did
> > not contain one, that setup would break from this *if* it didn't use
> > an initrd.
>
> I checked the Linux source, and the original code contributed by Roy
> already contained the logic to create the /chosen node if it wants
> there already. So we should be fine here.
Excellent. Then, with this information now in a public archive for any
unfortunate souls doing anything crazy non-linux to find:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
next prev parent reply other threads:[~2020-10-23 13:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 12:08 [PATCH 0/4] linux: implement LoadFile2 initrd loading Ard Biesheuvel
2020-10-23 12:08 ` [PATCH 1/4] loader/linux: permit NULL argument for argv[] in grub_initrd_load() Ard Biesheuvel
2020-10-23 12:08 ` [PATCH 2/4] efi: add definition of LoadFile2 protocol Ard Biesheuvel
2020-10-23 12:08 ` [PATCH 3/4] efi: implemented LoadFile2 initr loading protocol for Linux Ard Biesheuvel
2020-10-23 12:32 ` Leif Lindholm
2020-10-23 17:02 ` Ard Biesheuvel
2020-10-23 12:08 ` [PATCH 4/4] linux: ignore FDT unless we need to modify it Ard Biesheuvel
2020-10-23 12:47 ` Leif Lindholm
2020-10-23 13:12 ` Ard Biesheuvel
2020-10-23 13:16 ` Leif Lindholm [this message]
2020-10-23 12:50 ` [PATCH 0/4] linux: implement LoadFile2 initrd loading Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201023131604.GF1664@vanye \
--to=leif@nuviainc.com \
--cc=ard.biesheuvel@arm.com \
--cc=ardb@kernel.org \
--cc=daniel.kiper@oracle.com \
--cc=grub-devel@gnu.org \
--cc=linux-efi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).