From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26E30C433E6 for ; Sat, 6 Mar 2021 09:46:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD8E46501E for ; Sat, 6 Mar 2021 09:46:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229701AbhCFJpx (ORCPT ); Sat, 6 Mar 2021 04:45:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229635AbhCFJpZ (ORCPT ); Sat, 6 Mar 2021 04:45:25 -0500 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67681C06175F for ; Sat, 6 Mar 2021 01:45:25 -0800 (PST) Received: by mail-pj1-x102b.google.com with SMTP id kx1so559697pjb.3 for ; Sat, 06 Mar 2021 01:45:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OrPR8SCgp/TDBWi7TQcMhS3IkX8qoHvZgwUCqJ/NqdI=; b=VRreclAG1k+qmJNdv7UCkdEcWxdRgIfw2KSUezw924U3rjLMNqMTDHdg1v44ppVbr3 buAc14quQHiobY0ltDDBCIBL/eEY4D880Eyx6ukMYOzN1mXqVVJpd5ue+4H25bTFqqZ7 O3/wkdGUiRkZJMtPsd83OIU3uB6EAfawWEEC3ro3EnUURtiFx0rfeer0J2Hce1LZB4EP GHCPkwSx760blDs3L84B1FADusrcw0Gqi1xlpSltBqaKmh7fqi5urGVW7wA2Hf9ppBGY 3iVDz+f9NMgy/bNxGNwJDpjiJCe81q6D/15WClkIFl0TDVxFDgVkZaNkbSqpvIVIch+x +jCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OrPR8SCgp/TDBWi7TQcMhS3IkX8qoHvZgwUCqJ/NqdI=; b=pdpcSPwVhxp3a1hGyea2wqN2ks7DYrfnK0fhOs1mxX/7D1T7NUGf2u8ZbrRVmmJxk2 kdbd8Lm0gfwryfY3ZAnLUirgPeSf5pHUkqI79ouD89VNxCTA2mRALhjYF+JWDrhWT/zA sxxeJJjwu2vqzrBCZ2vy68GNnddV+uKq7wcmU+2nsy4XGu4KBxnMLs29zRPmF62ZiNbd /YfjlDshmGxR/6VU+DPXmMFSvZYmBZzM6j2PnxdAPtdp8VzyOroJHv0F5FLsGSii+vaP +dfAYVTwP+t3T55jZmKAAKbH3KUIyhEvxcdziUjGRY17Wp1/GqjP5wYhaN+N73MeJh4t YFzg== X-Gm-Message-State: AOAM530/9IoG1jivCevccdrkuh17QtLPdhdlm0lGBO8uK/nc2pvW/VIB 6eZ1KkpCQ65vP5QAgJ/Utd0Zjw== X-Google-Smtp-Source: ABdhPJww6KoYOO4ImE2czyutBV0PbuLHuBQcrCidHeKDkwgK+a87ViuaTr0ShjnDZt5YWmStw5MrNw== X-Received: by 2002:a17:902:768b:b029:e3:fb85:1113 with SMTP id m11-20020a170902768bb02900e3fb851113mr12606639pll.3.1615023925014; Sat, 06 Mar 2021 01:45:25 -0800 (PST) Received: from dragon (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id e1sm4573038pjt.10.2021.03.06.01.45.22 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 06 Mar 2021 01:45:24 -0800 (PST) Date: Sat, 6 Mar 2021 17:45:18 +0800 From: Shawn Guo To: Ard Biesheuvel Cc: linux-efi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jeffrey Hugo , Bjorn Andersson , Rob Clark , Leif Lindholm , linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 1/1] efi: stub: omit SetVirtualAddressMap() if marked unsupported in RT_PROP table Message-ID: <20210306094517.GN17424@dragon> References: <20210305093958.187358-1-ardb@kernel.org> <20210305093958.187358-2-ardb@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210305093958.187358-2-ardb@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Fri, Mar 05, 2021 at 10:39:58AM +0100, Ard Biesheuvel wrote: > The EFI_RT_PROPERTIES_TABLE contains a mask of runtime services that are > available after ExitBootServices(). This mostly does not concern the EFI > stub at all, given that it runs before that. However, there is one call > that is made at runtime, which is the call to SetVirtualAddressMap() > (which is not even callable at boot time to begin with) > > So add the missing handling of the RT_PROP table to ensure that we only > call SetVirtualAddressMap() if it is not being advertised as unsupported > by the firmware. > > Signed-off-by: Ard Biesheuvel On Lenovo Yoga C630 laptop: Tested-by: Shawn Guo It's a great help to dropping 'efi=novamap' kernel cmdline, which is a very nice thing for distros to support Snapdragon laptops. Thanks much, Ard! Shawn