From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F31F7C433F5 for ; Wed, 2 Feb 2022 04:15:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232389AbiBBEP5 (ORCPT ); Tue, 1 Feb 2022 23:15:57 -0500 Received: from cavan.codon.org.uk ([176.126.240.207]:50118 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230456AbiBBEP4 (ORCPT ); Tue, 1 Feb 2022 23:15:56 -0500 X-Greylist: delayed 836 seconds by postgrey-1.27 at vger.kernel.org; Tue, 01 Feb 2022 23:15:56 EST Received: by cavan.codon.org.uk (Postfix, from userid 1000) id 394B740A4A; Wed, 2 Feb 2022 04:01:57 +0000 (GMT) Date: Wed, 2 Feb 2022 04:01:57 +0000 From: Matthew Garrett To: James Bottomley Cc: Greg KH , Dov Murik , linux-efi@vger.kernel.org, Borislav Petkov , Ashish Kalra , Brijesh Singh , Tom Lendacky , Ard Biesheuvel , James Morris , "Serge E. Hallyn" , Andi Kleen , Andrew Scull , Dave Hansen , "Dr. David Alan Gilbert" , Gerd Hoffmann , Lenny Szubowicz , Peter Gonda , Tobin Feldman-Fitzthum , Jim Cadden , Daniele Buono , linux-coco@lists.linux.dev, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Nayna Jain , dougmill@linux.vnet.ibm.com, gcwilson@linux.ibm.com, gjoyce@ibm.com, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au, dja@axtens.net Subject: Re: [PATCH v7 0/5] Allow guest access to EFI confidential computing secret area Message-ID: <20220202040157.GA8019@srcf.ucam.org> References: <20220201124413.1093099-1-dovmurik@linux.ibm.com> <37779659ca96ac9c1f11bcc0ac0665895c795b54.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <37779659ca96ac9c1f11bcc0ac0665895c795b54.camel@linux.ibm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Tue, Feb 01, 2022 at 09:24:50AM -0500, James Bottomley wrote: > On Tue, 2022-02-01 at 14:50 +0100, Greg KH wrote: > > You all need to work together to come up with a unified place for > > this and stop making it platform-specific. We're talking about things that have massively different semantics. How do we expose that without an unwieldy API that has to try to be a superset of everything implemented, which then has to be extended when yet another implementation shows up with another behavioural quirk? EFI variables already need extremely careful handling to avoid rm -rf /sys bricking the system - should we impose that on everything, or should we allow the underlying implementation to leak through in some ways?