From: Hans de Goede <hdegoede@redhat.com>
To: "Rafael J . Wysocki" <rafael@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Dmitry Osipenko <dmitry.osipenko@collabora.com>,
Mark Gross <markgross@kernel.org>,
Andy Shevchenko <andy@kernel.org>,
Ard Biesheuvel <ardb@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org,
platform-driver-x86@vger.kernel.org, x86@kernel.org,
linux-efi@vger.kernel.org
Subject: [PATCH 0/2] Fix 2 5.19 power-off regressions caused by sys-off-handler work
Date: Fri, 8 Jul 2022 15:14:10 +0200 [thread overview]
Message-ID: <20220708131412.81078-1-hdegoede@redhat.com> (raw)
Hi All,
I noticed that my Lenovo Yoga Tablet 2 1050L was hanging on power-off again
with 5.19, even though I had implemented a workaround for this in 5.17 .
I quickly realized that this was caused by the recent sys-off-handler work
and fixed this by switching the workaround over to register_sys_off_handler
with a priority of SYS_OFF_PRIO_FIRMWARE + 1, so that the workaround runs
before acpi_power_off() get a chance to run.
This made me realize that the efi_power_off handler which sometimes is
used in preference of acpi_power_off had the same problem, so the second
patch in this series fixes that.
I plan to include patch 1/2 in a fixes pull-req to Linus soon. Ard,
if I can get your Ack for 2/2 then I can include this in the pull-req
if you want; or you can send this to Linus yourself.
Regards,
Hans
Hans de Goede (2):
platform/x86: x86-android-tablets: Fix Lenovo Yoga Tablet 2 830/1050
poweroff again
efi: Fix efi_power_off() not being run before acpi_power_off() when
necessary
drivers/firmware/efi/reboot.c | 21 +++++++++++----------
drivers/platform/x86/x86-android-tablets.c | 17 +++++++++++++----
2 files changed, 24 insertions(+), 14 deletions(-)
--
2.36.0
next reply other threads:[~2022-07-08 13:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 13:14 Hans de Goede [this message]
2022-07-08 13:14 ` [PATCH 1/2] platform/x86: x86-android-tablets: Fix Lenovo Yoga Tablet 2 830/1050 poweroff again Hans de Goede
2022-07-08 13:36 ` Dmitry Osipenko
2022-07-08 13:14 ` [PATCH 2/2] efi: Fix efi_power_off() not being run before acpi_power_off() when necessary Hans de Goede
2022-07-08 16:37 ` Ard Biesheuvel
2022-07-10 15:24 ` Hans de Goede
2022-07-08 13:29 ` [PATCH 0/2] Fix 2 5.19 power-off regressions caused by sys-off-handler work Dmitry Osipenko
2022-07-10 15:27 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220708131412.81078-1-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy@kernel.org \
--cc=ardb@kernel.org \
--cc=dmitry.osipenko@collabora.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox