From: Andrew Morton <akpm@linux-foundation.org>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Petr Mladek <pmladek@suse.com>,
evgreen@chromium.org, arnd@arndb.de, linux-efi@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@gpiccoli.net,
ardb@kernel.org, davidgow@google.com, jwerner@chromium.org
Subject: Re: [PATCH V3] firmware: google: Test spinlock on panic path to avoid lockups
Date: Thu, 1 Sep 2022 15:13:20 -0700 [thread overview]
Message-ID: <20220901151320.3cff1767f88cfb33f394e9cb@linux-foundation.org> (raw)
In-Reply-To: <794efe45-2fef-0d3f-b6d0-f2f451be850c@igalia.com>
On Thu, 1 Sep 2022 16:02:08 -0300 "Guilherme G. Piccoli" <gpiccoli@igalia.com> wrote:
> On 01/09/2022 15:59, Greg KH wrote:
> > [...]
> > Ick, I don't know, this all feels odd. I want someone else to review
> > this and give their ack on the patch before I'll take it so someone else
> > can share in the blame :)
> >
> > thanks,
> >
> > greg k-h
>
> LOL, that's OK for me! Evan seems to be fine with it BTW.
>
> Let's see if Petr can jump in, also adding Andrew here since he's
> usually merging stuff for panic.
Are the usual gsmi developers not operational?
Patch seems sensible to me, although the deadlock sounds pretty
theoretical. A better code comment might be simply
/*
* Panic callbacks are executed with all other CPUs stopped, so we must
* not attempt to spin waiting for gsmi_dev.lock to be released.
*/
?
next prev parent reply other threads:[~2022-09-01 22:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 15:50 [PATCH V3] firmware: google: Test spinlock on panic path to avoid lockups Guilherme G. Piccoli
2022-09-01 15:52 ` Greg KH
2022-09-01 15:59 ` Guilherme G. Piccoli
2022-09-01 16:04 ` Greg KH
2022-09-01 16:24 ` Guilherme G. Piccoli
2022-09-01 16:44 ` Greg KH
2022-09-01 17:46 ` Guilherme G. Piccoli
2022-09-01 18:28 ` Greg KH
2022-09-01 18:46 ` Guilherme G. Piccoli
2022-09-01 18:59 ` Greg KH
2022-09-01 19:02 ` Guilherme G. Piccoli
2022-09-01 22:13 ` Andrew Morton [this message]
2022-09-06 17:09 ` Evan Green
2022-09-08 0:35 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220901151320.3cff1767f88cfb33f394e9cb@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=davidgow@google.com \
--cc=evgreen@chromium.org \
--cc=gpiccoli@igalia.com \
--cc=gregkh@linuxfoundation.org \
--cc=jwerner@chromium.org \
--cc=kernel@gpiccoli.net \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox