RE: [PATCH v6 5/8] EDAC/ghes: Make ghes_edac a proper module to remove the dependency on ghes

Justin He
2022-09-25T15:07:37Z

Hi Borislav

> -----Original Message-----
> From: Borislav Petkov <bp@alien8.de>
> Sent: Friday, September 23, 2022 11:43 PM
> To: Justin He <Justin.He@arm.com>
> Cc: Len Brown <lenb@kernel.org>; James Morse <James.Morse@arm.com>;
> Tony Luck <tony.luck@intel.com>; Mauro Carvalho Chehab
> <mchehab@kernel.org>; Robert Richter <rric@kernel.org>; Robert Moore
> <robert.moore@intel.com>; Qiuxu Zhuo <qiuxu.zhuo@intel.com>; Yazen
> Ghannam <yazen.ghannam@amd.com>; Jan Luebbe <jlu@pengutronix.de>;
> Khuong Dinh <khuong@os.amperecomputing.com>; Kani Toshi
> <toshi.kani@hpe.com>; Ard Biesheuvel <ardb@kernel.org>;
> linux-acpi@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-edac@vger.kernel.org; devel@acpica.org; Rafael J . Wysocki
> <rafael@kernel.org>; Shuai Xue <xueshuai@linux.alibaba.com>; Jarkko
> Sakkinen <jarkko@kernel.org>; linux-efi@vger.kernel.org; nd <nd@arm.com>
> Subject: Re: [PATCH v6 5/8] EDAC/ghes: Make ghes_edac a proper module to
> remove the dependency on ghes
>
> On Thu, Sep 22, 2022 at 08:26:16AM +0000, Justin He wrote:
> > If there is no ghes_present flag.
> > What if ghes.disable is passed to kernel boot parameter and then
> > ghes_edac is loaded by modprobe?
> > Thus, ghes_edac can be loaded even if ghes is disabled. (ghes_dev list
> > is null)
>
> Yes, and what happens if ghes_dev is NULL?
>
Okay, I am fine if it is allowed to register ghes_dev with
> The other drivers would do in their init function:
>
> struct list_head *ghes_devs;
>
> ghes_devs = ghes_get_devices();
> if (ghes_devs)
> return -ENODEV;
>
> /* Continue init */
>
> and then load in that case because user has disabled GHES and thus no
> ghes_edac either. So the platform-specific one loads.

Okay, I am fine with removing ghes_present and ghes_edac_preferred if
It is ok to register empty ghes_dev list without prompting an error

--
Cheers,
Justin (Jia He)