From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-efi@vger.kernel.org, Daniel Kiper <dkiper@net-space.pl>,
Glenn Washburn <development@efficientek.com>
Subject: Re: [PATCH] efi/libstub: Disable PCI DMA before grabbing the EFI memory map
Date: Tue, 27 Jun 2023 09:00:39 +0100 [thread overview]
Message-ID: <20230627080039.GA20512@srcf.ucam.org> (raw)
In-Reply-To: <20230627074132.1016795-1-ardb@kernel.org>
On Tue, Jun 27, 2023 at 09:41:32AM +0200, Ard Biesheuvel wrote:
> However, the stub will invoke DisconnectController() on all endpoints
> downstream of the PCI bridges it disables, and this may affect the
> layout of the EFI memory map, making it likely that ExitBootServices()
> will fail the first time around, and that the EFI memory map needs to be
> reloaded.
Isn't it always likely that ExitBootServices() will fail the first time
around, but disable_early_pci_dma makes it more likely it'll have
changed by enough that we need a bigger map? Other than that potential
quibble over the changelog,
Acked-by: Matthew Garrett <mjg59@srcf.ucam.org>
next prev parent reply other threads:[~2023-06-27 8:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 7:41 [PATCH] efi/libstub: Disable PCI DMA before grabbing the EFI memory map Ard Biesheuvel
2023-06-27 8:00 ` Matthew Garrett [this message]
2023-06-27 8:14 ` Ard Biesheuvel
2023-06-27 8:17 ` Matthew Garrett
2023-06-27 8:32 ` Ard Biesheuvel
2023-06-27 8:37 ` Matthew Garrett
2023-06-27 8:47 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230627080039.GA20512@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=ardb@kernel.org \
--cc=development@efficientek.com \
--cc=dkiper@net-space.pl \
--cc=linux-efi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox