From: Borislav Petkov <bp@alien8.de>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
Evgeniy Baskov <baskov@ispras.ru>,
Andy Lutomirski <luto@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Alexey Khoroshilov <khoroshilov@ispras.ru>,
Peter Jones <pjones@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>, Dave Young <dyoung@redhat.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Kees Cook <keescook@chromium.org>,
Tom Lendacky <thomas.lendacky@amd.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Joerg Roedel <jroedel@suse.de>
Subject: Re: [PATCH v8 00/23] efi/x86: Avoid bare metal decompressor during EFI boot
Date: Sun, 6 Aug 2023 12:17:10 +0200 [thread overview]
Message-ID: <20230806101710.GAZM9zJjwoNKFSfWD6@fat_crate.local> (raw)
In-Reply-To: <CAMj1kXHi8=L8e=a5ci4yQFVrc=XqqJaMNvZuPXduwaAVfmm4_Q@mail.gmail.com>
On Sun, Aug 06, 2023 at 12:05:25PM +0200, Ard Biesheuvel wrote:
> I suspect this should fix the issue:
>
> --- a/arch/x86/kernel/head_64.S
> +++ b/arch/x86/kernel/head_64.S
> @@ -110,6 +110,7 @@ SYM_CODE_START_NOALIGN(startup_64)
> * programmed into CR3.
> */
> leaq _text(%rip), %rdi
> + movq %r15, %rsi
> call __startup_64
Yah, I was suspecting we're not passing boot_params properly somewhere.
Aaand there it is.
So yes, that fixes it.
Lemme know when you've refreshed your branch so that I can continue
testing.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2023-08-06 10:17 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 15:48 [PATCH v8 00/23] efi/x86: Avoid bare metal decompressor during EFI boot Ard Biesheuvel
2023-08-02 15:48 ` [PATCH v8 01/23] x86/decompressor: Don't rely on upper 32 bits of GPRs being preserved Ard Biesheuvel
2023-08-02 15:48 ` [PATCH v8 02/23] x86/head_64: Store boot_params pointer in callee save register Ard Biesheuvel
2023-08-02 15:48 ` [PATCH v8 03/23] x86/efistub: Branch straight to kernel entry point from C code Ard Biesheuvel
2023-08-02 15:48 ` [PATCH v8 04/23] x86/efistub: Simplify and clean up handover entry code Ard Biesheuvel
2023-08-02 15:48 ` [PATCH v8 05/23] x86/decompressor: Avoid magic offsets for EFI handover entrypoint Ard Biesheuvel
2023-08-02 15:48 ` [PATCH v8 06/23] x86/efistub: Clear BSS in EFI handover protocol entrypoint Ard Biesheuvel
2023-08-02 15:48 ` [PATCH v8 07/23] x86/decompressor: Store boot_params pointer in callee save register Ard Biesheuvel
2023-08-02 15:48 ` [PATCH v8 08/23] x86/decompressor: Assign paging related global variables earlier Ard Biesheuvel
2023-08-02 15:48 ` [PATCH v8 09/23] x86/decompressor: Call trampoline as a normal function Ard Biesheuvel
2023-08-02 15:48 ` [PATCH v8 10/23] x86/decompressor: Use standard calling convention for trampoline Ard Biesheuvel
2023-08-02 15:48 ` [PATCH v8 11/23] x86/decompressor: Avoid the need for a stack in the 32-bit trampoline Ard Biesheuvel
2023-08-02 15:48 ` [PATCH v8 12/23] x86/decompressor: Call trampoline directly from C code Ard Biesheuvel
2023-08-02 15:48 ` [PATCH v8 13/23] x86/decompressor: Only call the trampoline when changing paging levels Ard Biesheuvel
2023-08-02 15:48 ` [PATCH v8 14/23] x86/decompressor: Pass pgtable address to trampoline directly Ard Biesheuvel
2023-08-02 15:48 ` [PATCH v8 15/23] x86/decompressor: Merge trampoline cleanup with switching code Ard Biesheuvel
2023-08-02 15:48 ` [PATCH v8 16/23] x86/efistub: Perform 4/5 level paging switch from the stub Ard Biesheuvel
2023-08-02 15:48 ` [PATCH v8 17/23] x86/efistub: Prefer EFI memory attributes protocol over DXE services Ard Biesheuvel
2023-08-02 15:48 ` [PATCH v8 18/23] decompress: Use 8 byte alignment Ard Biesheuvel
2023-08-02 15:48 ` [PATCH v8 19/23] x86/decompressor: Move global symbol references to C code Ard Biesheuvel
2023-08-02 15:48 ` [PATCH v8 20/23] x86/decompressor: Factor out kernel decompression and relocation Ard Biesheuvel
2023-08-02 15:48 ` [PATCH v8 21/23] efi/libstub: Add limit argument to efi_random_alloc() Ard Biesheuvel
2023-08-02 15:48 ` [PATCH v8 22/23] x86/efistub: Perform SNP feature test while running in the firmware Ard Biesheuvel
2023-08-02 15:48 ` [PATCH v8 23/23] x86/efistub: Avoid legacy decompressor when doing EFI boot Ard Biesheuvel
2023-08-05 14:40 ` [PATCH v8 00/23] efi/x86: Avoid bare metal decompressor during " Borislav Petkov
2023-08-05 17:37 ` Ard Biesheuvel
2023-08-05 21:06 ` Borislav Petkov
2023-08-05 22:19 ` Ard Biesheuvel
2023-08-06 10:05 ` Ard Biesheuvel
2023-08-06 10:17 ` Borislav Petkov [this message]
2023-08-06 10:21 ` Ard Biesheuvel
2023-08-07 16:18 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230806101710.GAZM9zJjwoNKFSfWD6@fat_crate.local \
--to=bp@alien8.de \
--cc=ardb@kernel.org \
--cc=baskov@ispras.ru \
--cc=dave.hansen@linux.intel.com \
--cc=dyoung@redhat.com \
--cc=jroedel@suse.de \
--cc=keescook@chromium.org \
--cc=khoroshilov@ispras.ru \
--cc=kirill.shutemov@linux.intel.com \
--cc=kraxel@redhat.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pjones@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox