Re: [PATCH 0/3] Update LLVM Phabricator and Bugzilla links

Fangrui Song
2024-01-11T20:34:30Z

On Wed, Jan 10, 2024 at 4:46 PM Kees Cook <keescook@chromium.org> wrote:
>
> On Tue, Jan 09, 2024 at 03:16:28PM -0700, Nathan Chancellor wrote:
> > This series updates all instances of LLVM Phabricator and Bugzilla links
> > to point to GitHub commits directly and LLVM's Bugzilla to GitHub issue
> > shortlinks respectively.
> >
> > I split up the Phabricator patch into BPF selftests and the rest of the
> > kernel in case the BPF folks want to take it separately from the rest of
> > the series, there are obviously no dependency issues in that case. The
> > Bugzilla change was mechanical enough and should have no conflicts.
> >
> > I am aiming this at Andrew and CC'ing other lists, in case maintainers
> > want to chime in, but I think this is pretty uncontroversial (famous
> > last words...).
> >
> > ---
> > Nathan Chancellor (3):
> > selftests/bpf: Update LLVM Phabricator links
> > arch and include: Update LLVM Phabricator links
> > treewide: Update LLVM Bugzilla links
> >
> > arch/arm64/Kconfig | 4 +--
> > arch/powerpc/Makefile | 4 +--
> > arch/powerpc/kvm/book3s_hv_nested.c | 2 +-
> > arch/riscv/Kconfig | 2 +-
> > arch/riscv/include/asm/ftrace.h | 2 +-
> > arch/s390/include/asm/ftrace.h | 2 +-
> > arch/x86/power/Makefile | 2 +-
> > crypto/blake2b_generic.c | 2 +-
> > drivers/firmware/efi/libstub/Makefile | 2 +-
> > drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c | 2 +-
> > drivers/media/test-drivers/vicodec/codec-fwht.c | 2 +-
> > drivers/regulator/Kconfig | 2 +-
> > include/asm-generic/vmlinux.lds.h | 2 +-
> > include/linux/compiler-clang.h | 2 +-
> > lib/Kconfig.kasan | 2 +-
> > lib/raid6/Makefile | 2 +-
> > lib/stackinit_kunit.c | 2 +-
> > mm/slab_common.c | 2 +-
> > net/bridge/br_multicast.c | 2 +-
> > security/Kconfig | 2 +-
> > tools/testing/selftests/bpf/README.rst | 32 +++++++++++-----------
> > tools/testing/selftests/bpf/prog_tests/xdpwall.c | 2 +-
> > .../selftests/bpf/progs/test_core_reloc_type_id.c | 2 +-
> > 23 files changed, 40 insertions(+), 40 deletions(-)
> > ---
> > base-commit: 0dd3ee31125508cd67f7e7172247f05b7fd1753a
> > change-id: 20240109-update-llvm-links-d03f9d649e1e
> >
> > Best regards,
> > --
> > Nathan Chancellor <nathan@kernel.org>
> >
>
> Excellent! Thanks for doing this. I spot checked a handful I was
> familiar with and everything looks good to me.
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>
> --
> Kees Cook
>

These reviews.llvm.org links would definitely be kept like
https://lists.llvm.org/pipermail/llvm-dev/ or cfe-dev links
(discussions have been migrated to Discourse).
However, I agree that the github repo link looks more official. I have
clicked a few links and they look good.

Since I maintain reviews.llvm.org and created the static archive [1],

Acked-by: Fangrui Song <maskray@google.com>

[1]: https://discourse.llvm.org/t/llvm-phabricator-turndown/76137

--
宋方睿