Re: [PATCH v9 05/19] x86: Secure Launch main header file

ross.philipson
2024-06-04T20:53:46Z

On 6/4/24 11:24 AM, Jarkko Sakkinen wrote:
> On Fri May 31, 2024 at 4:03 AM EEST, Ross Philipson wrote:
>> Introduce the main Secure Launch header file used in the early SL stub
>> and the early setup code.
>>
>> Signed-off-by: Ross Philipson <ross.philipson@oracle.com>
>
> Right and anything AMD specific should also have legit references. I
> actually always compare to the spec when I review, so not just
> nitpicking really.
>
> I'm actually bit confused, is this usable both Intel and AMD in the
> current state? Might be just that have not had time follow this for some
> time.

This header file mostly has TXT/Intel specific definitions in it right
now but that is just because TXT is the first target architecture. I am
working on the AMD side of things as we speak and yes, AMD specific
definitions will go in here and later ARM specific definitions too.

If you would like to see say a comment block with links to relevant
specifications in this header file, that can be done and they will be
added as new support is added.

Thanks
Ross

>
> BR, Jarkko
>