From: Jonathan Marek <jonathan@marek.ca>
To: linux-efi@vger.kernel.org
Cc: Ard Biesheuvel <ardb@kernel.org>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 3/3] efi/libstub: consider CONFIG_CMDLINE for initrd= and dtb= options
Date: Fri, 11 Oct 2024 18:48:02 -0400 [thread overview]
Message-ID: <20241011224812.25763-3-jonathan@marek.ca> (raw)
In-Reply-To: <20241011224812.25763-1-jonathan@marek.ca>
Replace cmdline with CONFIG_CMDLINE when it should be used instead of
load_options.
In the EXTEND case, it may be necessary to combine both CONFIG_CMDLINE and
load_options. In that case, keep the old behavior and print a warning about
the incorrect behavior.
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
---
drivers/firmware/efi/libstub/file.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/firmware/efi/libstub/file.c b/drivers/firmware/efi/libstub/file.c
index d6a025df07dcf..2a69e2b3583d4 100644
--- a/drivers/firmware/efi/libstub/file.c
+++ b/drivers/firmware/efi/libstub/file.c
@@ -208,6 +208,18 @@ efi_status_t handle_cmdline_files(efi_loaded_image_t *image,
if (IS_ENABLED(CONFIG_X86) && !efi_nochunk)
efi_chunk_size = EFI_READ_CHUNK_SIZE;
+ if (IS_ENABLED(CONFIG_CMDLINE_EXTEND) ||
+ IS_ENABLED(CONFIG_CMDLINE_FORCE) ||
+ cmdline_len == 0) {
+ if (!IS_ENABLED(CONFIG_CMDLINE_FORCE) && cmdline_len > 0) {
+ /* both CONFIG_CMDLINE and load_options should be used */
+ efi_warn("ignoring %ls from CONFIG_CMDLINE\n", optstr);
+ } else {
+ cmdline = L"" CONFIG_CMDLINE;
+ cmdline_len = ARRAY_SIZE(L"" CONFIG_CMDLINE) - 1;
+ }
+ }
+
alloc_addr = alloc_size = 0;
do {
struct finfo fi;
--
2.45.1
next prev parent reply other threads:[~2024-10-11 22:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 22:48 [PATCH 1/3] efi/libstub: fix efi_parse_options() ignoring the default command line Jonathan Marek
2024-10-11 22:48 ` [PATCH 2/3] efi/libstub: remove uneccessary cmdline_size init/check Jonathan Marek
2024-10-12 7:49 ` Ard Biesheuvel
2024-10-11 22:48 ` Jonathan Marek [this message]
2024-10-12 7:54 ` [PATCH 3/3] efi/libstub: consider CONFIG_CMDLINE for initrd= and dtb= options Ard Biesheuvel
2024-10-12 12:00 ` Jonathan Marek
2024-10-12 13:36 ` Ard Biesheuvel
2024-10-12 14:07 ` Jonathan Marek
2024-10-12 14:50 ` Ard Biesheuvel
2024-10-12 15:00 ` Jonathan Marek
2024-10-15 0:13 ` kernel test robot
2024-10-15 2:08 ` kernel test robot
2024-10-12 7:46 ` [PATCH 1/3] efi/libstub: fix efi_parse_options() ignoring the default command line Ard Biesheuvel
2024-10-12 11:55 ` Jonathan Marek
2024-10-12 13:15 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241011224812.25763-3-jonathan@marek.ca \
--to=jonathan@marek.ca \
--cc=ardb@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox