From: Al Viro <viro@zeniv.linux.org.uk>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-efi@vger.kernel.org,
Ard Biesheuvel <ardb@kernel.org>, Jeremy Kerr <jk@ozlabs.org>
Subject: Re: [PATCH 6/6] efivarfs: fix error on write to new variable leaving remnants
Date: Mon, 23 Dec 2024 20:05:13 +0000 [thread overview]
Message-ID: <20241223200513.GO1977892@ZenIV> (raw)
In-Reply-To: <f9690563fe9d7ae4db31dd37650777e02580b332.camel@HansenPartnership.com>
On Mon, Dec 23, 2024 at 02:52:12PM -0500, James Bottomley wrote:
>
> +static int efivarfs_file_release(struct inode *inode, struct file *file)
> +{
> + inode_lock(inode);
> + if (i_size_read(inode) == 0 && !d_unhashed(file->f_path.dentry)) {
> + drop_nlink(inode);
> + d_delete(file->f_path.dentry);
> + dput(file->f_path.dentry);
> + }
> + inode_unlock(inode);
> + return 0;
> +}
This is wrong; so's existing logics for removal from write(). Think
what happens if you open the sucker, have something bound on top of
it and do that deleting write().
Let me look into that area...
next prev parent reply other threads:[~2024-12-23 20:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 17:02 [PATCH 0/6] convert efivarfs to manage object data correctly James Bottomley
2024-12-10 17:02 ` [PATCH 1/6] efivarfs: remove unused efi_varaible.Attributes and .kobj James Bottomley
2024-12-10 17:02 ` [PATCH 2/6] efivarfs: add helper to convert from UC16 name and GUID to utf8 name James Bottomley
2024-12-10 17:02 ` [PATCH 3/6] efivarfs: make variable_is_present use dcache lookup James Bottomley
2024-12-10 17:14 ` Dionna Amalie Glaze
2024-12-10 17:27 ` James Bottomley
2024-12-23 20:20 ` Al Viro
2024-12-23 21:44 ` James Bottomley
2024-12-10 17:02 ` [PATCH 4/6] efivarfs: move freeing of variable entry into evict_inode James Bottomley
2024-12-11 11:19 ` Christian Brauner
2024-12-10 17:02 ` [PATCH 5/6] efivarfs: remove unused efivarfs_list James Bottomley
2024-12-10 17:02 ` [PATCH 6/6] efivarfs: fix error on write to new variable leaving remnants James Bottomley
2024-12-11 11:16 ` Christian Brauner
2024-12-11 12:39 ` James Bottomley
2024-12-23 19:52 ` James Bottomley
2024-12-23 20:05 ` Al Viro [this message]
2024-12-23 21:39 ` James Bottomley
2024-12-23 22:56 ` James Bottomley
2024-12-23 23:12 ` Al Viro
2024-12-24 4:04 ` James Bottomley
2024-12-24 4:44 ` Al Viro
2024-12-24 13:07 ` James Bottomley
2024-12-24 15:09 ` James Bottomley
2024-12-27 14:52 ` James Bottomley
2024-12-19 17:14 ` James Bottomley
2024-12-22 10:12 ` Christian Brauner
2024-12-23 19:44 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241223200513.GO1977892@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=James.Bottomley@hansenpartnership.com \
--cc=ardb@kernel.org \
--cc=brauner@kernel.org \
--cc=jk@ozlabs.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox