Re: [PATCH 3/9] efi: Remove redundant creation of the "efivars" platform device

Ard Biesheuvel
2025-03-17T17:06:37Z

On Mon, 17 Mar 2025 at 11:13, Sudeep Holla <sudeep.holla@arm.com> wrote:
>
> The "efivars" platform device is created but never tracked or used,
> as there is no driver associated with it. Since this device serves
> no functional purpose, removing its creation without affecting any
> functionality.
>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: linux-efi@vger.kernel.org
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> drivers/firmware/efi/efi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
> index 7309394b8fc98cf7a3424af209b752f0251c8c89..eec173cb1f398d3b4f28b42c917e50e1728dc277 100644
> --- a/drivers/firmware/efi/efi.c
> +++ b/drivers/firmware/efi/efi.c
> @@ -446,7 +446,6 @@ static int __init efisubsys_init(void)
> error = efivar_ssdt_load();
> if (error)
> pr_err("efi: failed to load SSDT, error %d.\n", error);
> - platform_device_register_simple("efivars", 0, NULL, 0);
> }
>
> BLOCKING_INIT_NOTIFIER_HEAD(&efivar_ops_nh);
>

IIRC the efi-pstore module autoloads based on this platform device