Re: [PATCH 4/9] rtc: efi: Transition to the faux device interface

Sudeep Holla
2025-03-17T14:04:12Z

On Mon, Mar 17, 2025 at 02:07:00PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Mar 17, 2025 at 10:13:16AM +0000, Sudeep Holla wrote:
> > The EFI RTC driver does not require the creation of a platform device.
> > Originally, this approach was chosen for simplicity when the driver was
> > first implemented.
> >
> > With the introduction of the lightweight faux device interface, we now
> > have a more appropriate alternative. Migrate the driver to utilize the
> > faux bus, given that the platform device it previously created was not
> > a real one anyway. This will simplify the code, reducing its footprint
> > while maintaining functionality.
> >
> > Cc: Ard Biesheuvel <ardb@kernel.org>
> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> > Cc: linux-rtc@vger.kernel.org
> > Cc: linux-efi@vger.kernel.org
> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> > ---
> > drivers/firmware/efi/efi.c | 3 ---
> > drivers/rtc/rtc-efi.c | 31 ++++++++++++++++++++++---------
> > 2 files changed, 22 insertions(+), 12 deletions(-)
> >

[...]

> > -MODULE_ALIAS("platform:rtc-efi");
> > +MODULE_ALIAS("faux:rtc-efi");
>
> No alias please.

Thanks for the review, will drop all the alias.

--
Regards,
Sudeep