From: Sudeep Holla <sudeep.holla@arm.com>
To: linux-kernel@vger.kernel.org
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ard Biesheuvel <ardb@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-rtc@vger.kernel.org, linux-efi@vger.kernel.org
Subject: [PATCH v2 4/8] rtc: efi: Transition to the faux device interface
Date: Tue, 18 Mar 2025 17:01:42 +0000 [thread overview]
Message-ID: <20250318-plat2faux_dev-v2-4-e6cc73f78478@arm.com> (raw)
In-Reply-To: <20250318-plat2faux_dev-v2-0-e6cc73f78478@arm.com>
The EFI RTC driver does not require the creation of a platform device.
Originally, this approach was chosen for simplicity when the driver was
first implemented.
With the introduction of the lightweight faux device interface, we now
have a more appropriate alternative. Migrate the driver to utilize the
faux bus, given that the platform device it previously created was not
a real one anyway. This will simplify the code, reducing its footprint
while maintaining functionality.
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org
Cc: linux-efi@vger.kernel.org
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
drivers/firmware/efi/efi.c | 3 ---
drivers/rtc/rtc-efi.c | 16 +++++-----------
2 files changed, 5 insertions(+), 14 deletions(-)
diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index 7309394b8fc98cf7a3424af209b752f0251c8c89..8aebc747c65bc1b63d514a50fe6f35a9e3c1af0a 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -427,9 +427,6 @@ static int __init efisubsys_init(void)
}
}
- if (efi_rt_services_supported(EFI_RT_SUPPORTED_TIME_SERVICES))
- platform_device_register_simple("rtc-efi", 0, NULL, 0);
-
/* We register the efi directory at /sys/firmware/efi */
efi_kobj = kobject_create_and_add("efi", firmware_kobj);
if (!efi_kobj) {
diff --git a/drivers/rtc/rtc-efi.c b/drivers/rtc/rtc-efi.c
index fa8bf82df9488e7d1c23c058b4a3032dde74bc6e..681d917d541e51b37f2d59b0567caf6aa8bf05f4 100644
--- a/drivers/rtc/rtc-efi.c
+++ b/drivers/rtc/rtc-efi.c
@@ -14,7 +14,7 @@
#include <linux/module.h>
#include <linux/stringify.h>
#include <linux/time.h>
-#include <linux/platform_device.h>
+#include <linux/device/faux.h>
#include <linux/rtc.h>
#include <linux/efi.h>
@@ -254,7 +254,7 @@ static const struct rtc_class_ops efi_rtc_ops = {
.proc = efi_procfs,
};
-static int __init efi_rtc_probe(struct platform_device *dev)
+static int __init efi_rtc_probe(struct faux_device *dev)
{
struct rtc_device *rtc;
efi_time_t eft;
@@ -268,7 +268,7 @@ static int __init efi_rtc_probe(struct platform_device *dev)
if (IS_ERR(rtc))
return PTR_ERR(rtc);
- platform_set_drvdata(dev, rtc);
+ faux_device_set_drvdata(dev, rtc);
rtc->ops = &efi_rtc_ops;
clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, rtc->features);
@@ -282,15 +282,9 @@ static int __init efi_rtc_probe(struct platform_device *dev)
return devm_rtc_register_device(rtc);
}
-static struct platform_driver efi_rtc_driver = {
- .driver = {
- .name = "rtc-efi",
- },
-};
-
-module_platform_driver_probe(efi_rtc_driver, efi_rtc_probe);
+module_faux_driver(rtc_efi, efi_rtc_probe, NULL,
+ efi_rt_services_supported(EFI_RT_SUPPORTED_TIME_SERVICES));
MODULE_AUTHOR("dann frazier <dannf@dannf.org>");
MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("EFI RTC driver");
-MODULE_ALIAS("platform:rtc-efi");
--
2.34.1
next prev parent reply other threads:[~2025-03-18 17:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 17:01 [PATCH v2 0/8] drivers: Transition to the faux device interface Sudeep Holla
2025-03-18 17:01 ` Sudeep Holla [this message]
2025-04-08 14:45 ` (subset) [PATCH v2 4/8] rtc: efi: " Alexandre Belloni
2025-04-08 15:01 ` Sudeep Holla
2025-03-18 17:01 ` [PATCH v2 5/8] virt: efi_secret: " Sudeep Holla
2025-03-18 17:10 ` Ard Biesheuvel
2025-03-19 13:15 ` Sudeep Holla
2025-03-19 14:24 ` Greg Kroah-Hartman
2025-03-19 14:30 ` Sudeep Holla
2025-03-18 17:01 ` [PATCH v2 6/8] efi: efivars: " Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250318-plat2faux_dev-v2-4-e6cc73f78478@arm.com \
--to=sudeep.holla@arm.com \
--cc=alexandre.belloni@bootlin.com \
--cc=ardb@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox