Re: [PATCH] efi: pstore: Support late setup with TEE-backed efivars ops

Kees Cook
2025-12-10T14:28:56Z

On Wed, Dec 10, 2025 at 06:13:17PM +0900, Ard Biesheuvel wrote:
> On Wed, 10 Dec 2025 at 17:41, kernel test robot <oliver.sang@intel.com> wrote:
> >
> >
> >
> > Hello,
> >
> > kernel test robot noticed "WARNING:at_kernel/locking/rwsem.c:#__down_write_trylock" on:
> >
> > commit: 6f473fefec79a8ba24013a5676a93934ee5ac922 ("[PATCH] efi: pstore: Support late setup with TEE-backed efivars ops")
> > url: https://github.com/intel-lab-lkp/linux/commits/Val-Packett/efi-pstore-Support-late-setup-with-TEE-backed-efivars-ops/20251203-123406
> > base: https://git.kernel.org/cgit/linux/kernel/git/kees/linux.git for-next/pstore
> > patch link: https://lore.kernel.org/all/20251203042850.14210-1-val@packett.cool/
> > patch subject: [PATCH] efi: pstore: Support late setup with TEE-backed efivars ops
> >
> > in testcase: boot
> >
> > config: i386-randconfig-015-20251207
> > compiler: clang-20
> > test machine: qemu-system-i386 -enable-kvm -cpu SandyBridge -smp 2 -m 4G
> >
> > (please refer to attached dmesg/kmsg for entire log/backtrace)
> >
> >
> > +---------------------------------------------------------+------------+------------+
> > | | b692553573 | 6f473fefec |
> > +---------------------------------------------------------+------------+------------+
> > | WARNING:at_kernel/locking/rwsem.c:#__down_write_trylock | 0 | 18 |
> > | EIP:__down_write_trylock | 0 | 18 |
> > | WARNING:at_kernel/locking/rwsem.c:#up_write | 0 | 18 |
> > | EIP:up_write | 0 | 18 |
> > +---------------------------------------------------------+------------+------------+
> >
>
> This seems to be a non-EFI boot, in which case the notifier chain is
> never initialized.
>
> Kees, can you drop this from your branch so we can get it fixed? I
> also had some review feedback that hasn't been taken into account yet.

I didn't take it -- this appears to be patch-based 0day randconfig. (I'd
rather it went via EFI anyway, too.)

-Kees

--
Kees Cook