public inbox for linux-efi@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] efi: Drop unused efi_range_is_wc() function
@ 2026-03-09 12:53 Ard Biesheuvel
  2026-03-11 16:10 ` Ilias Apalodimas
  0 siblings, 1 reply; 2+ messages in thread
From: Ard Biesheuvel @ 2026-03-09 12:53 UTC (permalink / raw)
  To: linux-efi; +Cc: Ard Biesheuvel

From: Ard Biesheuvel <ardb@kernel.org>

efi_range_is_wc() has no callers, so remove it.

Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
 include/linux/efi.h | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/include/linux/efi.h b/include/linux/efi.h
index 664898d09ff5..72e76ec54641 100644
--- a/include/linux/efi.h
+++ b/include/linux/efi.h
@@ -832,27 +832,6 @@ extern int __init parse_efi_signature_list(
 	const void *data, size_t size,
 	efi_element_handler_t (*get_handler_for_guid)(const efi_guid_t *));
 
-/**
- * efi_range_is_wc - check the WC bit on an address range
- * @start: starting kvirt address
- * @len: length of range
- *
- * Consult the EFI memory map and make sure it's ok to set this range WC.
- * Returns true or false.
- */
-static inline int efi_range_is_wc(unsigned long start, unsigned long len)
-{
-	unsigned long i;
-
-	for (i = 0; i < len; i += (1UL << EFI_PAGE_SHIFT)) {
-		unsigned long paddr = __pa(start + i);
-		if (!(efi_mem_attributes(paddr) & EFI_MEMORY_WC))
-			return 0;
-	}
-	/* The range checked out */
-	return 1;
-}
-
 /*
  * We play games with efi_enabled so that the compiler will, if
  * possible, remove EFI-related code altogether.
-- 
2.53.0.473.g4a7958ca14-goog


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] efi: Drop unused efi_range_is_wc() function
  2026-03-09 12:53 [PATCH] efi: Drop unused efi_range_is_wc() function Ard Biesheuvel
@ 2026-03-11 16:10 ` Ilias Apalodimas
  0 siblings, 0 replies; 2+ messages in thread
From: Ilias Apalodimas @ 2026-03-11 16:10 UTC (permalink / raw)
  To: Ard Biesheuvel; +Cc: linux-efi, Ard Biesheuvel

On Mon, 9 Mar 2026 at 14:53, Ard Biesheuvel <ardb+git@google.com> wrote:
>
> From: Ard Biesheuvel <ardb@kernel.org>
>
> efi_range_is_wc() has no callers, so remove it.
>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>

>  include/linux/efi.h | 21 ---------------------
>  1 file changed, 21 deletions(-)
>
> diff --git a/include/linux/efi.h b/include/linux/efi.h
> index 664898d09ff5..72e76ec54641 100644
> --- a/include/linux/efi.h
> +++ b/include/linux/efi.h
> @@ -832,27 +832,6 @@ extern int __init parse_efi_signature_list(
>         const void *data, size_t size,
>         efi_element_handler_t (*get_handler_for_guid)(const efi_guid_t *));
>
> -/**
> - * efi_range_is_wc - check the WC bit on an address range
> - * @start: starting kvirt address
> - * @len: length of range
> - *
> - * Consult the EFI memory map and make sure it's ok to set this range WC.
> - * Returns true or false.
> - */
> -static inline int efi_range_is_wc(unsigned long start, unsigned long len)
> -{
> -       unsigned long i;
> -
> -       for (i = 0; i < len; i += (1UL << EFI_PAGE_SHIFT)) {
> -               unsigned long paddr = __pa(start + i);
> -               if (!(efi_mem_attributes(paddr) & EFI_MEMORY_WC))
> -                       return 0;
> -       }
> -       /* The range checked out */
> -       return 1;
> -}
> -
>  /*
>   * We play games with efi_enabled so that the compiler will, if
>   * possible, remove EFI-related code altogether.
> --
> 2.53.0.473.g4a7958ca14-goog
>
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-03-11 16:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-09 12:53 [PATCH] efi: Drop unused efi_range_is_wc() function Ard Biesheuvel
2026-03-11 16:10 ` Ilias Apalodimas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox