From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14FE523FC5A for ; Sun, 15 Mar 2026 22:20:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773613239; cv=none; b=P+iGQeb96oDnwtgeLxETZeSTbdMXrx0V7OCqbJMZDAYbrQ3ID4E84WH8wMGGZ95JE+lDMrQ+g/UMy7ayejHwOASYloI11URIVRb6PudzP0H1JuGLak39qHw8ETYT/073YQNsmirDpd5JJCn/IlQ9xTY6m119+FhjGnsSIdruVtU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773613239; c=relaxed/simple; bh=d4jChEeUUc0f0rEMKPi4UAZuovkMFjwzj0INK1YLEaU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Z4vL8z9oiTJK0fxygqe+exPf/WYENkooj8GOEkFJCazWeSXDddxYaV/MA5/ITWwbco7FfoBV7JYxBL2NzZL849fbMbvT0Wvqy/Me1aLDNs17UiWrZubd2ToU0Q0T2mnpSZ6qvV0UaJBjMgS5n6JCm8OYpITaLU1spyQmSFNS710= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iFR7tdAk; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iFR7tdAk" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-35a288a2c00so1008028a91.2 for ; Sun, 15 Mar 2026 15:20:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773613237; x=1774218037; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R6JQWklIlJSZA3P4ZxqqueLAj4IsTzAWLg/HK7yKGJM=; b=iFR7tdAkoXa6GcKRjWuVOjC3094LSGTHCn3uQqDthbXeCtAzrheOF2a3jTYYN3CJsn 7AVKRcGWbEAD7QmBdi8Tj1pE0RO9gNHYIaE83tvFlD1nQGgORVCzi7upWh/ntLhzoh7O TAfEvueDN5KqVVQca5s/hoJRK2TKsXR0JGqZihd2vt4CXCflzfI5mzLv8F+b9iYI8/7e 7Lc94dYYwc3THFb3/2M0XxUzujFFkM9iaMbgQmZruB/1Wcpo+ncBjzDkueUhU498BbbP bb9YPTXed7QjTW0iMYtzRF5UXwaOh1HMmjN8hECUy9cV/3RfZoeB7LlRVGghE6IUVydk hm4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773613237; x=1774218037; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=R6JQWklIlJSZA3P4ZxqqueLAj4IsTzAWLg/HK7yKGJM=; b=bzcB9SXuyMrnpkPQJFuzznrJFOTx0Mjs5YyMHDCPHFEzdm0K4ILMYB9cr0W+ClRFS4 PHhL46D23GJENdKi4q3DOvVtgTpyrxpYmghPNMUCi5ypqMHezyF8+ab1K3BHhmtLMtvK gOpIN8JZ8lqFhmyFFRC4vchInovPd6arrfKQ7ab1l7BEd2GQ+Rqn3K4JK3aMlI7EDY8q eoMwzTEn3JCfsf2BvpnDZ518aFTmYQmO3uFQ9/I+zdweEntPBEWtm71dmfxsd6gIVcfU n+gfiXo2RZ0FkUSJ3btxIxeAljReNt1SGnmpnW5mxmGgp+Knwb9jOEKegyjS8nqiazEI MYwA== X-Forwarded-Encrypted: i=1; AJvYcCWefd2skpLQtmPWLF7IV8fwYAEpvdrOWv+zY+QoFKDLiuaIRVJQw6OUL1CS1UHtVdScRc0+ohCmg0o=@vger.kernel.org X-Gm-Message-State: AOJu0YyJAh0gRU7jf5cqFJxQho4dvxnmEJL6C9o2nXdRVozVab7O0p7T FnqRV3FC1CKYFOY5/HI0NRisc3g7hhZKcpHLIH8Cxup0NG0DDd2Ic9w= X-Gm-Gg: ATEYQzzPzGnoKAzfV1jTLvUPS0HdcdS/vN+Oz5Vl0rXuUo/vBtflWernJQFpu56jr3X DKNfbSwoOgYiObah6IgVRbkDri97xNJUKDRkMGxxYP8fLTTwZhSQFxIK6WdNuKcsrl3zpPN4Nd8 DUq0TiA/EDHMfg5/rq4GNIheODitCtWLLSlwxxstLRq304MvZZYTJrlDRxvcn2WoVa8qLWBwe3H Xr9jVnPE3FmC5G4yu5WT/bkDREwVckeRgb/TKZVtLv/rTH1BeZ5QIb5NmU4u5AYhNwMc+0y9CBm Up+a+CUlpfozTc8ip5/DFWcVomYsP8JWBk+od6nk956nQzdvNNQOCGLVfxd97trIZnNu4qYlUrx PFmOdPihjrStoyIIfXnsDrW8Qwj78a5/MftT3ekjXewmaYHOZDRFOq7AiS3iFjMD24d7Kn/zJia GJROOl+xu/Lv6mkhF9BjR8hh4C58qxD6u9dxC3599PLuAD8HJEO6BwQzjh16Si/aUjAXKNZfjJE g== X-Received: by 2002:a17:90b:1d09:b0:33b:bed8:891c with SMTP id 98e67ed59e1d1-35a22053278mr9573278a91.23.1773613237313; Sun, 15 Mar 2026 15:20:37 -0700 (PDT) Received: from at-Standard-PC-Q35-ICH9-2009.. ([171.61.163.197]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35b98f0e5a6sm2547141a91.5.2026.03.15.15.20.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Mar 2026 15:20:37 -0700 (PDT) From: Atharva Tiwari To: Cc: Atharva Tiwari , Lukas Wunner , Ard Biesheuvel , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , linux-kernel@vger.kernel.org (open list), linux-efi@vger.kernel.org (open list:EXTENSIBLE FIRMWARE INTERFACE (EFI)), platform-driver-x86@vger.kernel.org (open list:X86 PLATFORM DRIVERS) Subject: [PATCH v3 1/2] efi: Save Brightness using EFI on Macs Date: Mon, 16 Mar 2026 03:49:59 +0530 Message-ID: <20260315222020.24341-2-atharvatiwarilinuxdev@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260315222020.24341-1-atharvatiwarilinuxdev@gmail.com> References: <20260315222020.24341-1-atharvatiwarilinuxdev@gmail.com> Precedence: bulk X-Mailing-List: linux-efi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently when a Mac reboots, the brightness is not the same as the previous boot instead its the same as the last time the Mac booted macOS. We can fix this issue by saving the brightness level to the efivar backlight-level. (tested on iMac20,1) Suggested-by: Lukas Wunner Signed-off-by: Atharva Tiwari --- drivers/firmware/efi/Kconfig | 10 +++ drivers/firmware/efi/Makefile | 1 + drivers/firmware/efi/apple-brightness.c | 67 +++++++++++++++++++ .../linux/platform_data/apple-brightness.h | 20 ++++++ 4 files changed, 98 insertions(+) create mode 100644 drivers/firmware/efi/apple-brightness.c create mode 100644 include/linux/platform_data/apple-brightness.h diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig index 29e0729299f5..dd0a9c9a772a 100644 --- a/drivers/firmware/efi/Kconfig +++ b/drivers/firmware/efi/Kconfig @@ -167,6 +167,16 @@ config APPLE_PROPERTIES If unsure, say Y if you have a Mac. Otherwise N. +config APPLE_BRIGHTNESS + bool "Apple Backlight control for EFI" + depends on X86 + help + This will save the brightness level to EFI, so brightness + level is preserved across reboots and shutdows. allowing + for improved support of Apple hardware. + + If unsure, say Y if you have a Mac, Otherwise N. + config RESET_ATTACK_MITIGATION bool "Reset memory attack mitigation" depends on EFI_STUB diff --git a/drivers/firmware/efi/Makefile b/drivers/firmware/efi/Makefile index 8efbcf699e4f..1f5705cc87a2 100644 --- a/drivers/firmware/efi/Makefile +++ b/drivers/firmware/efi/Makefile @@ -26,6 +26,7 @@ obj-$(CONFIG_EFI_BOOTLOADER_CONTROL) += efibc.o obj-$(CONFIG_EFI_TEST) += test/ obj-$(CONFIG_EFI_DEV_PATH_PARSER) += dev-path-parser.o obj-$(CONFIG_APPLE_PROPERTIES) += apple-properties.o +obj-$(CONFIG_APPLE_BRIGHTNESS) += apple-brightness.o obj-$(CONFIG_EFI_RCI2_TABLE) += rci2-table.o obj-$(CONFIG_EFI_EMBEDDED_FIRMWARE) += embedded-firmware.o obj-$(CONFIG_LOAD_UEFI_KEYS) += mokvar-table.o diff --git a/drivers/firmware/efi/apple-brightness.c b/drivers/firmware/efi/apple-brightness.c new file mode 100644 index 000000000000..b060861b0795 --- /dev/null +++ b/drivers/firmware/efi/apple-brightness.c @@ -0,0 +1,67 @@ +// SPDX-License-Identifier: GPL-2.0-only OR MIT +/* + * apple-brightness.c - EFI brightness saver on Macs + * Copyright (C) 2026 Atharva Tiwari + */ + +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + +#include +#include +#include + +static u32 efi_attr; +static u16 last_saved_level; + +static int (*get_brightness)(struct backlight_device *bl); +static struct backlight_device *bl_dev; + +void apple_brightness_shutdown(void) +{ + u16 level; + efi_status_t status; + + level = (u16)get_brightness(bl_dev); + + if (level == last_saved_level) + return; + + status = efivar_set_variable(APPLE_BRIGHTNESS_NAME, &APPLE_BRIGHTNESS_GUID, + efi_attr, sizeof(level), &level); + if (status != EFI_SUCCESS) + pr_debug("Unable to set brightness: 0x%lx\n", status); +} +EXPORT_SYMBOL(apple_brightness_shutdown); + +int apple_brightness_probe(struct backlight_device *bl, + int (*get_brightnessfn)(struct backlight_device *bl)) +{ + efi_status_t status; + unsigned long size = sizeof(last_saved_level); + int ret; + + bl_dev = bl; + get_brightness = get_brightnessfn; + + if (!efi_rt_services_supported(EFI_RT_SUPPORTED_SET_VARIABLE)) + return -ENODEV; + + ret = efivar_lock(); + if (ret) + return ret; + + status = efivar_get_variable(APPLE_BRIGHTNESS_NAME, &APPLE_BRIGHTNESS_GUID, + &efi_attr, &size, &last_saved_level); + + efivar_unlock(); + + if (status != EFI_SUCCESS) + return -ENODEV; + + return 0; +} +EXPORT_SYMBOL(apple_brightness_probe); + +MODULE_AUTHOR("Atharva Tiwari "); +MODULE_DESCRIPTION("EFI Brightness saver for Macs"); +MODULE_LICENSE("Dual MIT/GPL"); diff --git a/include/linux/platform_data/apple-brightness.h b/include/linux/platform_data/apple-brightness.h new file mode 100644 index 000000000000..54e3f3f8aa1c --- /dev/null +++ b/include/linux/platform_data/apple-brightness.h @@ -0,0 +1,20 @@ +/* SPDX-License-Identifier: GPL-2.0-only OR MIT */ +/* + * apple-brightness.h - EFI brightness saver for Macs + * Copyright (C) 2026 Atharva Tiwari + */ + +#ifndef _APPLE_BL_H_ +#define _APPLE_BL_H_ + +#include +#include + +#define APPLE_BRIGHTNESS_NAME L"backlight-level" +#define APPLE_BRIGHTNESS_GUID EFI_GUID(0x7c436110, 0xab2a, 0x4bbb, 0xa8, 0x80, 0xfe, 0x41, 0x99, 0x5c, 0x9f, 0x82) + +int apple_brightness_probe(struct backlight_device *bl, + int (*get_brightnessfn)(struct backlight_device *bl)); + +void apple_brightness_shutdown(void); +#endif /* _APPLE_BL_H */ -- 2.43.0