Linux EFI development
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@debian.org>
To: Ard Biesheuvel <ardb@kernel.org>,
	 Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	 Josh Poimboeuf <jpoimboe@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	 Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Breno Leitao <leitao@debian.org>,
	kernel-team@meta.com,  kernel test robot <lkp@intel.com>
Subject: [PATCH 0/2] efi/runtime-wrappers: fix linker warnings
Date: Mon, 13 Jul 2026 06:06:46 -0700	[thread overview]
Message-ID: <20260713-efi_fixes-v1-0-cdde378d9df9@debian.org> (raw)

When I've submitted my last patchset titled "efi/runtime-wrappers: bound
the wait for EFI runtime service calls", I've got two reports

1) efi_rts_park_worker() loops forever and never returns, but wasn't
marked __noreturn, so objtool warns about the unreachable code after
the call.
https://lore.kernel.org/all/202607100848.iWPxdkhX-lkp@intel.com/

2) efi_runtime_lock_owner is optimised away under CONFIG_BUG=n, leaving a
dangling debug-info reference that breaks the link.
https://lore.kernel.org/all/202607100518.uMJJPDfP-lkp@intel.com/

Patch 1 fixes the objtool warning; patch 2 fixes the link error.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
Breno Leitao (2):
      efi/runtime-wrappers: mark efi_rts_park_worker() as __noreturn
      efi/runtime-wrappers: mark efi_runtime_lock_owner as __used

 drivers/firmware/efi/runtime-wrappers.c | 4 ++--
 include/linux/efi.h                     | 2 +-
 tools/objtool/noreturns.h               | 1 +
 3 files changed, 4 insertions(+), 3 deletions(-)
---
base-commit: cf790fdb851867532b9a0f88588dcce648dbffe9
change-id: 20260713-efi_fixes-b7193dd37bcf

Best regards,
--  
Breno Leitao <leitao@debian.org>


             reply	other threads:[~2026-07-13 13:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-13 13:06 Breno Leitao [this message]
2026-07-13 13:06 ` [PATCH 1/2] efi/runtime-wrappers: mark efi_rts_park_worker() as __noreturn Breno Leitao
2026-07-13 13:06 ` [PATCH 2/2] efi/runtime-wrappers: mark efi_runtime_lock_owner as __used Breno Leitao
2026-07-14  6:50 ` [PATCH 0/2] efi/runtime-wrappers: fix linker warnings Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260713-efi_fixes-v1-0-cdde378d9df9@debian.org \
    --to=leitao@debian.org \
    --cc=ardb@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jpoimboe@kernel.org \
    --cc=kernel-team@meta.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox