From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06D6941D214 for ; Mon, 14 Sep 2026 21:44:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789422292; cv=none; b=aE4VkRjq10ty06Bv+z8fhhajl5bo8o8Qh4/I9V2Wl2OD0rpBxId7L4OVOnzK+pzipD1l7vANiWQTEqGbKqLAEtfepg2tfYzN0/ntgfBMM5D8o/copuG4n0rrQerb3iX6DktrP5Zk3qKaQtxs/aprBgQhJI8x6HK46a/iivzB9Yw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789422292; c=relaxed/simple; bh=jq28sXgMOG83pqsfn4DsTwpWb6M2x0VMwZWrEfMyIQw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=AD+06ze+9Z8r09YrwvJj4weZP2fiSWOPTiH8ZSjPu7cOJwl9+wABVduYQxxF+LPVgkyI2NFrJNEKu4ZisGcCI7plfV5Srrg1TdNCggRp66P9NEYV+O9ZHmfAOcwxwGTuIdlw5FAwQylb7F/bWhGovi0cxu60dSBHH+HKPTgeSEI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F5k0jKWA; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F5k0jKWA" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-49e6b280cadso32607295e9.1 for ; Mon, 14 Sep 2026 14:44:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789422288; x=1790027088; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=MMWuFoZNpTbVauKFWQOZe8Q8+oQNvVLrh3IMG7Y4F/I=; b=F5k0jKWA5V7fsrPZW1nrHXuRGeJXyZ58u3g3QbvJYBLesJa7CsHFAcUr8F6NDqwRZg rldl7fTLMER31itXf6qPIcl5CK2PeJI/mtnDyg4h3IsTrxctV/75DAFB7xz+71jc8jHI FTSPkI6hSWQePq2HVJovw4Y0Qhbs11GUMbzc4npv+ply1DiqrpenWVxLy0/mp0QHhPPA apF+kSzyr+CS5A2IMOgQlxZ4/G47QCoDPsQezvtRAYpKyRE2qIQln9KxX5iMdnkqs9Z5 4igLWbBdBqy8XCJkGoUoOGIncMjtJ7IPRa+WaIklABXnV2vaoqDENZuuSoEbc8ciwmD3 W5cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789422288; x=1790027088; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MMWuFoZNpTbVauKFWQOZe8Q8+oQNvVLrh3IMG7Y4F/I=; b=Edvjh2UBN49iGN0GkZyYR8jeV47Im4pShg20evH5GFDfoWJYYx5HW/l/xOhpc9uCWh /Sry/napA9yjuyrnVBXa7oXj3+bqahWwEMjb8CUX5gu//i1gL5cJrsOQaxFnShBJEwvQ P4RjQzlIbtYd90M7ySJ12VVcExxButXGYnId75IIwGDkDyLxYFP0ccVjaa3iJ+pgSKF7 PYplv2Yjl7gCyMepmltUNipoOeUlxGPA8SH6i6Y2L2lemAnevOo1nEEhUQOge+7FJAF4 tGxmON2X4+3M0uozKJ0ZkGbCpgF2Mdc3CmzsNd2bIA28Z3JCiO0Apc+pyVj8jVp79RCP oHEw== X-Forwarded-Encrypted: i=1; AKwUvBwPmrg555sX2/86+ZcAJeUsBeGWTT/ZCfSgDWRiISeZKJDivHwBDyxF+UTSg/wCnShPgZlZA94pFTk=@vger.kernel.org X-Gm-Message-State: AFuF++mHaunDFgB/kppEL2NpgmQAr9u8hA6GrL9wpwY4DSGPIGQ7NsbE b0eOITqp8amIJT9X2f8D6D8xpuiNbhoRe//eIZzi1aBVJHWUEnw4ajF6 X-Gm-Gg: AYBFou09PajB0jZ+BN66HVVohQtK5yIRXAZd9ASioEt0Lq9Kr2CjBGi32dUXYsB6Bvr picl7xc+4if4GTWRRNZukzjYJlakrGjab4GzurRtTs6JCQ3FilRQa12XNo+YnDqCydU8iA1ioGI uWG+40+zcgCWrHzMU8A4L205dlL+fjVRBqdD/oL8a2lqXquM9e/3lN99zcQGs+eDRSGBhTp3hW8 OGH/j94F95AwYD76kBzp4EQ0KzF1MyBsV+b99FsoABFAEooftVZougyQV/4AU64rcwEzLbDjgcH OFuKs9tD4yD8dGYl5njbmqMocJKytBpJnCsiYBl6m/fmjJNzjbRmzZqsugLDgs7LbWD7wiEr1BG XHdZHFMv1XdkytnbNUG5ZGPrl9Q7vhMEM4bJt8DErHemHSAls00v2uYhxDgwtgYmG9IGhN54mgn v/5GgFvckvlaVH4Mz1hEDzA5WiRRJ7Y+5nTlGykfeJvWhpZfxE5nYPcHhE3okYp+exgqb3F0HEH e9FyJnncNOhnm/lvO2bjtiRruJa6NMX4/Lk X-Received: by 2002:a05:6000:454f:b0:487:36a:c870 with SMTP id ffacd0b85a97d-487036ac895mr3178523f8f.11.1789422288113; Mon, 14 Sep 2026 14:44:48 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-486eb2ed0fbsm29878025f8f.3.2026.09.14.14.44.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 14:44:47 -0700 (PDT) Date: Mon, 14 Sep 2026 22:44:32 +0100 From: David Laight To: Markus Elfring Cc: Lorenzo Stoakes , linux-kbuild@vger.kernel.org, x86@kernel.org, Albert Ou , Alexandre Courbot , Alexandre Ghiti , Alexey Gladkov , Alice Ryhl , Andreas Hindborg , Ard Biesheuvel , Arnd Bergmann , Benno Lossin , Bill Wendling , =?UTF-8?B?QmrDtnJu?= Roy Baron , Boqun Feng , Borislav Petkov , Catalin Marinas , Daniel Almeida , Danilo Krummrich , Dave Hansen , Gary Guo , "Gustavo A. R. Silva" , "H. Peter Anvin" , Ilias Apalodimas , Ingo Molnar , Jonathan Corbet , Josh Poimboeuf , Justin Stitt , Kees Cook , Linus Torvalds , Mark Rutland , Masahiro Yamada , Miguel Ojeda , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Onur =?UTF-8?B?w5Z6a2Fu?= , Palmer Dabbelt , Paul Walmsley , Peter Zijlstra , Randy Dunlap , Tamir Duberstein , Thomas Gleixner , Trevor Gross , Will Deacon , LKML , kernel-janitors@vger.kernel.org, linux-hardening@vger.kernel.org, linux-doc@vger.kernel.org, linux-efi@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-arch@vger.kernel.org, llvm@lists.linux.dev, linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Jens Axboe Subject: Re: [PATCH v2 03/21] kallsyms: output binary data to speed output and kallsyms assembly Message-ID: <20260914224432.7ed40d48@pumpkin> In-Reply-To: References: <20260914-build-speedup-v2-3-39817ec5db23@kernel.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-efi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 14 Sep 2026 22:16:12 +0200 Markus Elfring wrote: > =E2=80=A6 > > +++ b/scripts/kallsyms.c =20 > =E2=80=A6 > > @@ -413,26 +438,24 @@ static void write_src(void) > > /* Encode length with ULEB128. */ > > if (table[i]->len <=3D 0x7F) { > > /* Most symbols use a single byte for the length. */ > > - printf("\t.byte 0x%02x", table[i]->len); > > + fputc(table[i]->len, out_bin_file); > > off +=3D table[i]->len + 1; > > } else { > > /* "Big" symbols use two bytes. */ > > - printf("\t.byte 0x%02x, 0x%02x", > > - (table[i]->len & 0x7F) | 0x80, > > - (table[i]->len >> 7) & 0x7F); > > + fputc((table[i]->len & 0x7F) | 0x80, out_bin_file); > > + fputc((table[i]->len >> 7) & 0x7F, out_bin_file); > > off +=3D table[i]->len + 2; > > } > > - for (k =3D 0; k < table[i]->len; k++) > > - printf(", 0x%02x", table[i]->sym[k]); > > + fwrite(table[i]->sym, 1, table[i]->len, out_bin_file); > > =20 > > /* > > * Now that we wrote out the compressed symbol name, restore the > > - * original name and print it in the comment. > > + * original name for the comments below. > > */ > > expand_symbol(table[i]->sym, table[i]->len, buf); > > strcpy((char *)table[i]->sym, buf); > > - printf("\t/* %s */\n", table[i]->sym); > > } > > + write_incbin(out_bin_name, bin_start, bin_pos(out_bin_file)); > > printf(".size kallsyms_names, . - kallsyms_names\n"); > > printf("\n"); > > =20 > =E2=80=A6 >=20 > I suggest to avoid return value ignorance a bit more. > https://cmu-sei.github.io/secure-coding-standards/sei-cert-c-coding-stand= ard/rules/error-handling-err/err33-c/ > https://cwe.mitre.org/data/definitions/252.html And I suggest you do some real coding... The error is sticky and can be checked using ferror(). Code that looks at the return value from fprintf() fwrite() etc is very often broken because the only time they can actual fail is when the buffer is flushed during close. Adding error checks to every call just make the code unreadable. David >=20 > Regards, > Markus