Re: [PATCH 0/8] Some pstore improvements

Kees Cook
2022-10-12T17:59:21Z

On Wed, Oct 12, 2022 at 12:50:50PM -0300, Guilherme G. Piccoli wrote:
> On 06/10/2022 20:24, Kees Cook wrote:
> > On Thu, 6 Oct 2022 19:42:04 -0300, Guilherme G. Piccoli wrote:
> >> overall. Most of them are minors, but the implicit conversion thing
> >> is a bit more "relevant" in a sense it's more invasive and would fit
> >> more as a "fix".
> >>
> >> The code is based on v6.0, and it was tested with multiple compression
> >> algorithms (zstd, deflate, lz4, lzo, 842) and two backends (ramoops and
> >> efi_pstore) - I've used a QEMU UEFI guest and Steam Deck for this goal.
> >>
> >> [...]
> >
> > Applied to for-next/pstore, thanks!
> >
> > [1/8] pstore: Improve error reporting in case of backend overlap
> > https://git.kernel.org/kees/c/55dbe25ee4c8
> > [2/8] pstore: Expose kmsg_bytes as a module parameter
> > https://git.kernel.org/kees/c/1af13c2b6324
> > [3/8] pstore: Inform unregistered backend names as well
> > https://git.kernel.org/kees/c/a4f92789f799
> >
>
> Thanks Kees! just a heads-up on how I'll proceed.
>
> (a) Patches 1-3 were added already.
>
> (b) MAINTAINERS patch was reworked by yourself in the other series, so
> I'll discard my version.
>
> (c) I'll rework patches 4 and 8 and re-submit them plus patch 7
> (including the ACK from Ard).
>
> (d) Gonna discard for now patch 5, planning to test a new version on top
> of the crypto acomp interface V2 from Ard/you.

Sounds good; thanks!

--
Kees Cook