From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Thomas Zimmermann" <tzimmermann@suse.de>,
"Arnd Bergmann" <arnd@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>
Cc: "kernel test robot" <lkp@intel.com>,
"Evangelos Petrongonas" <epetron@amazon.de>,
"Mike Rapoport" <rppt@kernel.org>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] efi: export sysfb_primary_display for EDID
Date: Fri, 13 Feb 2026 19:22:57 +0100 [thread overview]
Message-ID: <2ee747d7-e000-439f-bda2-0b2ad050ed61@app.fastmail.com> (raw)
In-Reply-To: <80fd8ea2-bca0-4a8c-a442-77beefc06105@suse.de>
On Fri, 13 Feb 2026, at 19:17, Thomas Zimmermann wrote:
> Am 13.02.26 um 17:51 schrieb Arnd Bergmann:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> The sysfb_primary_display structure is now part of efi-init.c but
>> conditionally defined. One of the users is missing in the condition:
>>
>> aarch64-linux-ld: drivers/video/fbdev/core/fbmon.o: in function `fb_firmware_edid':
>> fbmon.c:(.text.fb_firmware_edid+0x3c): undefined reference to `sysfb_primary_display'
>>
>> Export it whenever CONFIG_FIRMWARE_EDID is set, so the fbdev core
>> code can use it.
>>
>> Fixes: 4fcae6358871 ("sysfb: Move edid_info into sysfb_primary_display")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202602111543.Do4nkY5l-lkp@intel.com/
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> Thanks for the fix.
>
Indeed, thanks for the fix. I'll queue this up and get it out soon.
prev parent reply other threads:[~2026-02-13 18:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 16:51 [PATCH] efi: export sysfb_primary_display for EDID Arnd Bergmann
2026-02-13 18:17 ` Thomas Zimmermann
2026-02-13 18:22 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ee747d7-e000-439f-bda2-0b2ad050ed61@app.fastmail.com \
--to=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=epetron@amazon.de \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=rppt@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox