From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDE4649620 for ; Wed, 15 Apr 2026 09:57:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776247041; cv=none; b=JDcUe3f4TAGv9P8vYI8IPHVSHaUpc6FTw6Tkgbusd6+WuEN27AWGlfnJhnZUuAT1FieN35HxK00IcuNZ1x0FStHifQDmlprEe3VhbeEX2uZJbmLLcvbgyCYRbSo1KzHfe57XQmRN/CvUDtjNcN5VmG79+u2z5WO049z4v2fCnb4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776247041; c=relaxed/simple; bh=wH1QJ5TIoR8oX2w9Na/+u1m1rf0anCjBEQAWOnhtT00=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=pJAfrsQCCqwJk01YxWnfz613Xxu5dv911KHAuosngCS7cWRkRm8ha/V/4iToXczJky5Id3mFvxYcsCJrHfaBaxolxtZVB07OX+y0g9LQNWuyOG5zO/BBFb/WHQvY/HQwRHmbJtRIMsoeB9cPO9LIMHVc89clABir/bTjUCse0xw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uXykSiGU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uXykSiGU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16ABBC19424; Wed, 15 Apr 2026 09:57:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776247041; bh=wH1QJ5TIoR8oX2w9Na/+u1m1rf0anCjBEQAWOnhtT00=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=uXykSiGUMkzGeKIAYXg4pmGp9TnEvttockT1kfCKoKEW0qpGzQ0KXG8EGgxH1JiD9 WZV+3PVpb2QCveuL2F+4QKA8cFdJIRlqVoJKrH2fAtl8WWPar3dG7tgFRbVvt8Nxo+ u1/e8VU1y7Zj9O0uAQPDiTnY33uvkl8+69H5rTwkgwGMelSa+/TyUGQpcL6lwQLwws eJm5dVY8s02JcWemJR8kkd3pNRNmNSJBwBibIenXv3MMQyvTBX2KG+guq6LkERByPe rMYJXs/60xbfQuX0sO5accC3g3M+ew1zk48A/NX9Lyuk2n9HmdPR3J0TN8dZyW5eIM gQywBmEFdeSdg== Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfauth.phl.internal (Postfix) with ESMTP id 1683EF4006A; Wed, 15 Apr 2026 05:57:20 -0400 (EDT) Received: from phl-imap-02 ([10.202.2.81]) by phl-compute-01.internal (MEProxy); Wed, 15 Apr 2026 05:57:20 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdegfeejkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefoggffhffvvefkjghfufgtgfesthejredtredttdenucfhrhhomhepfdetrhguuceu ihgvshhhvghuvhgvlhdfuceorghruggssehkvghrnhgvlhdrohhrgheqnecuggftrfgrth htvghrnhepvdeuheeitdevtdelkeduudetgffftdelteefteevjeevjeeiheefhfejieej fedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrugdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqudeijedthedttdejledq feefvdduieegudehqdgrrhgusgeppehkvghrnhgvlhdrohhrghesfihorhhkohhfrghrug drtghomhdpnhgspghrtghpthhtohepledpmhhouggvpehsmhhtphhouhhtpdhrtghpthht ohepphgrlhhmvghrsegurggssggvlhhtrdgtohhmpdhrtghpthhtoheprghouhesvggvtg hsrdgsvghrkhgvlhgvhidrvgguuhdprhgtphhtthhopehthhgvtghhrghrlhgvshhjvghn khhinhhssehgmhgrihhlrdgtohhmpdhrtghpthhtoheprghnughrihihrdhshhgvvhgthh gvnhhkohesihhnthgvlhdrtghomhdprhgtphhtthhopehpjhifsehkvghrnhgvlhdrohhr ghdprhgtphhtthhopegrkhhpmheslhhinhhugidqfhhouhhnuggrthhiohhnrdhorhhgpd hrtghpthhtoheplhhinhhugidqrhhishgtvheslhhishhtshdrihhnfhhrrgguvggrugdr ohhrghdprhgtphhtthhopehlihhnuhigqdgvfhhisehvghgvrhdrkhgvrhhnvghlrdhorh hgpdhrtghpthhtohepughmrghnthhiphhovheshigrnhguvgigrdhruh X-ME-Proxy: Feedback-ID: ice86485a:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id E2013700065; Wed, 15 Apr 2026 05:57:19 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-efi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Wed, 15 Apr 2026 11:56:59 +0200 From: "Ard Biesheuvel" To: "Andy Shevchenko" , "Dmitry Antipov" Cc: "Andrew Morton" , "Charlie Jenkins" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , linux-riscv@lists.infradead.org, linux-efi@vger.kernel.org Message-Id: <33c3e393-eacc-4ac2-97e4-5ce45c1b6604@app.fastmail.com> In-Reply-To: References: <20260414102608.573555-1-dmantipov@yandex.ru> <20260414102608.573555-4-dmantipov@yandex.ru> Subject: Re: [PATCH v4 3/3] riscv: fix building compressed EFI image Content-Type: text/plain Content-Transfer-Encoding: 7bit On Wed, 15 Apr 2026, at 11:52, Andy Shevchenko wrote: > On Tue, Apr 14, 2026 at 01:26:08PM +0300, Dmitry Antipov wrote: >> When building vmlinuz.efi with CONFIG_EFI_ZBOOT enabled, >> '__lshrdi3()' is also needed to fix yet another link error: >> >> riscv32-linux-gnu-ld: drivers/firmware/efi/libstub/lib-cmdline.stub.o: in function `__efistub_.L49': >> __efistub_cmdline.c:(.init.text+0x202): undefined reference to `__efistub___lshrdi3' >> >> And since riscv64 can have CONFIG_EFI_ZBOOT but doesn't need these >> library routines, introduce CONFIG_EFI_ZBOOT_USE_LIBGCC to manage >> linking of lib-ashldi3.o and lib-lshrdi3.o on riscv32 only. > > Acked-by: Andy Shevchenko > > I think you need a tag from Ard on this. > I don't think we need a new Kconfig symbol for this. Better do something like zboot-riscv-obj-$(CONFIG_32BIT) += lib-ashldi3.o lib-lshrdi3.o zboot-obj-$(CONFIG_RISCV) += lib-clz_ctz.o $(zboot-riscv-obj-y)