From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51169111A4; Tue, 7 Nov 2023 09:38:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22FB292; Tue, 7 Nov 2023 01:38:19 -0800 (PST) Received: from lhrpeml100001.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4SPjjl0dvWz67mKT; Tue, 7 Nov 2023 17:34:51 +0800 (CST) Received: from lhrpeml500006.china.huawei.com (7.191.161.198) by lhrpeml100001.china.huawei.com (7.191.160.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 7 Nov 2023 09:38:16 +0000 Received: from lhrpeml500006.china.huawei.com ([7.191.161.198]) by lhrpeml500006.china.huawei.com ([7.191.161.198]) with mapi id 15.01.2507.031; Tue, 7 Nov 2023 09:38:16 +0000 From: Shiju Jose To: Ira Weiny , Jonathan Cameron CC: Dan Williams , Smita Koralahalli , Yazen Ghannam , Davidlohr Bueso , Dave Jiang , Alison Schofield , "Vishal Verma" , Ard Biesheuvel , "linux-efi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-cxl@vger.kernel.org" Subject: RE: [PATCH RFC v3 1/6] cxl/trace: Remove uuid from event trace known events Thread-Topic: [PATCH RFC v3 1/6] cxl/trace: Remove uuid from event trace known events Thread-Index: AQHaDQgRQ2vINXGk70OHbaqSCzYaYrBoqc8AgAAYFhCABR7LgIAAwHxA Date: Tue, 7 Nov 2023 09:38:16 +0000 Message-ID: <36f2d12934d64a278f2c0313cbd01abc@huawei.com> References: <20230601-cxl-cper-v3-0-0189d61f7956@intel.com> <20230601-cxl-cper-v3-1-0189d61f7956@intel.com> <20231103142756.00000e20@Huawei.com> <547d055eb85d4cee9c636c69e89a82ed@huawei.com> <65496333c1dc9_90fed29479@iweiny-mobl.notmuch> In-Reply-To: <65496333c1dc9_90fed29479@iweiny-mobl.notmuch> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.126.168.44] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-efi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-CFilter-Loop: Reflected Hi Ira, >-----Original Message----- >From: Ira Weiny >Sent: 06 November 2023 22:06 >To: Shiju Jose ; Jonathan Cameron >; Ira Weiny >Cc: Dan Williams ; Smita Koralahalli >; Yazen Ghannam >; Davidlohr Bueso ; Dave >Jiang ; Alison Schofield ; >Vishal Verma ; Ard Biesheuvel ; >linux-efi@vger.kernel.org; linux-kernel@vger.kernel.org; linux- >cxl@vger.kernel.org >Subject: RE: [PATCH RFC v3 1/6] cxl/trace: Remove uuid from event trace kn= own >events > >Shiju Jose wrote: >> >> >> >-----Original Message----- >> >From: Jonathan Cameron >> >Sent: 03 November 2023 14:28 >> >To: Ira Weiny >> >Cc: Dan Williams ; Smita Koralahalli >> >; Yazen Ghannam >> >; Davidlohr Bueso ; Dave >> >Jiang ; Alison Schofield >> >; Vishal Verma >> >; Ard Biesheuvel ; >> >linux-efi@vger.kernel.org; linux-kernel@vger.kernel.org; linux- >> >cxl@vger.kernel.org; Shiju Jose >> >Subject: Re: [PATCH RFC v3 1/6] cxl/trace: Remove uuid from event >> >trace known events >> > >> >On Wed, 01 Nov 2023 14:11:18 -0700 >> >Ira Weiny wrote: >> > >> >> The uuid printed in the well known events is redundant. The uuid >> >> defines what the event was. >> >> >> >> Remove the uuid from the known events and only report it in the >> >> generic event as it remains informative there. >> >> >> >> Reviewed-by: Davidlohr Bueso >> >> Reviewed-by: Dan Williams >> >> Signed-off-by: Ira Weiny >> > >> >Removing the print is fine, but look like this also removes the >> >actual trace point field. That's userspace ABI. Expanding it is >> >fine, but taking fields away is more problematic. >> > >> >Are we sure we don't break anyone? Shiju, will rasdaemon be fine >> >with this change? >> >> The field hdr_uuid is removed from the common CXL_EVT_TP_entry shared >> by the trace events cxl_generic_event, cxl_general_media, cxl_dram and >cxl_memory_module . >> rasdaemon will break because of this while processing these trace >> events and also affects the corresponding error records in the SQLite da= ta >base. >> Rasdaemon needs update to avoid this. >> > >Ok we can leave the uuid field in easy enough. > >But does rasdaemon use the value of the field for anything? In other word= s does >CPER record processing need to generate a proper UUID value? No. Presently used for logging purpose only in the rasdaemon. > >Ira Thanks, Shiju