Re: [PATCH] efivarfs: fix NULL dereference on resume

James Bottomley
2025-03-18T14:52:13Z

On Tue, 2025-03-18 at 15:13 +0100, Christian Brauner wrote:
> > (which is what that vfs_kern_mount() boils down to).  But I would
> > very much prefer to have it go over the list of children of -
> > >s_root manually, instead of playing silly buggers with
> > iterate_dir().
>
> This is what I suggested earlier in the thread to rewrite it to not
> rely on files. That's probably the full-on fix we want later.

So as I said in the other reply, I think I can do that as a libfs.c
helper. However, it definitely won't be -fixes material and since this
is a current bug, is it OK if the patch goes up as is and I'll do the
rewrite for the merge window branch (and probably the next merge window
not this one, given where we are)? If I haven't got something by
LSF/MM you can yell at me in person ...

Regards,

James