linux-efi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeremy Kerr <jeremy.kerr-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
To: Lingzhu Xiang <lxiang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Matt Fleming
	<matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>,
	Matthew Garrett <mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] selftests: Add tests for efivarfs
Date: Tue, 22 Jan 2013 12:54:19 +0800	[thread overview]
Message-ID: <50FE1B7B.9040100@canonical.com> (raw)
In-Reply-To: <50FD1B1E.5000208-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Hi Lingzhu,

Thanks for taking a look at the patch.

>> +	# the open-unlink test relies on deleting the Lang variable at
>> +	# present; we don't want to do this on an actual machine.
>
> It seems open-unlink already goes to delete a custom variable.

Ah, this was left over from an older version of the test. Given that 
it's already caused problems, I'll remove the QEMU check.

Unless we're planning to brick machines in other nasty ways? :)

> test_zero_size_delete can't reproduce the file lingering bug on unpatched
> 3.8-rc4.

It's not intended to reproduce this particular issue. Would you be okay 
to add a specific test for this?

Cheers,


Jeremy

      parent reply	other threads:[~2013-01-22  4:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-18  9:19 [PATCH] selftests: Add tests for efivarfs Jeremy Kerr
2013-01-21 10:40 ` Lingzhu Xiang
     [not found]   ` <50FD1B1E.5000208-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-01-22  4:54     ` Jeremy Kerr [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50FE1B7B.9040100@canonical.com \
    --to=jeremy.kerr-z7wlfzj8ewms+fvcfc7uqw@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lxiang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org \
    --cc=mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).