linux-efi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lingzhu Xiang <lxiang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Matt Fleming <matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Joseph Yasi <joe.yasi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Josh Boyer <jwboyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: efivarfs: guid part of filenames are case-insensitive is broken
Date: Tue, 05 Mar 2013 16:38:03 +0800	[thread overview]
Message-ID: <5135AEEB.9090408@redhat.com> (raw)
In-Reply-To: <CADzA9okmNOS429FJNEAMj7gUMKD9bU8jzznCoJ_=tyySGDE++A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On 03/05/2013 05:46 AM, Joseph Yasi wrote:
> Hi,
> 
> With linux 3.8.2 I can no longer mount efivars on my Lenovo Thinkpad T530:
> 
> $ sudo mount -v /sys/firmware/efi/efivars
> mount: Cannot allocate memory

Looking at 47f531e8ba3bc3901a0c493f4252826c41dea1a1
efivarfs: Validate filenames much more aggressively

In efivarfs_valid_name:

+	/* GUID should be right after the first '-' */
+	if (s - 1 != strchr(str, '-'))
+		return false;

But pstore creates entries like dump-type0-1-$timestamp-$GUID.

efivarfs_alloc_dentry fails because it thinks pstore entry names
are invalid.

EFI pstore dump is now enabled by default (as in Fedora), saving
dump sooner or later, so users will likely be affected by this.

Manually creating a test-test-$GUID also reproduces this.


Lingzhu Xiang

  parent reply	other threads:[~2013-03-05  8:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-04 21:46 efivarfs: guid part of filenames are case-insensitive is broken Joseph Yasi
     [not found] ` <CADzA9okmNOS429FJNEAMj7gUMKD9bU8jzznCoJ_=tyySGDE++A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-03-05  8:38   ` Lingzhu Xiang [this message]
     [not found]     ` <5135AEEB.9090408-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-03-05 12:34       ` Matt Fleming
     [not found]         ` <1362486844.15011.8.camel-ZqTwcBeJ+wsBof6jY8KHXm7IUlhRatedral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-03-05 20:25           ` Joseph Yasi
2013-03-06  7:41           ` Lingzhu Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5135AEEB.9090408@redhat.com \
    --to=lxiang-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=joe.yasi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=jwboyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).