From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: Curious crash with secure variables Date: Mon, 18 Mar 2013 15:16:34 +0000 Message-ID: <51472FD2.6020205@console-pimps.org> References: <1363593684.2412.5.camel@dabdike.int.hansenpartnership.com> <1363607345.15011.339.camel@mfleming-mobl1.ger.corp.intel.com> <1363616613.2412.19.camel@dabdike.int.hansenpartnership.com> <51472C81.5020801@console-pimps.org> <1363619058.11342.74.camel@i7.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1363619058.11342.74.camel-W2I5cNIroUsVm/YvaOjsyQ@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: David Woodhouse Cc: James Bottomley , linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jordan L Justen List-Id: linux-efi@vger.kernel.org On 03/18/2013 03:04 PM, David Woodhouse wrote: > On Mon, 2013-03-18 at 15:02 +0000, Matt Fleming wrote: >> On 03/18/2013 02:23 PM, James Bottomley wrote: >>> Yes, it's a phenomenally complicated operation from looking at the >>> TianoCore source ... might we not be better off not bothering to >>> relocate and just using a private physical mapping for the calls? >> >> Yeah, there have been various discussions about doing this. I sent some >> patches last year but they broke various non-EFI machines and I haven't >> had chance to pick it up again. > > Got a pointer? I may take a look... > See, commit 53b87cf0 ("x86, mm: Include the entire kernel memory map in trampoline_pgd"), commit 185034e7 ("x86, efi: 1:1 pagetable mapping for virtual EFI calls"), commit da5a108d05b4 ("x86/kernel: remove tboot 1:1 page table creation code") and commit bd52276fa1d4 ("x86-64/efi: Use EFI to deal with platform wall clock (again)") and the two revert commits from Linus, be354f40 and 11520e5e. -- Matt Fleming, Intel Open Source Technology Center