[PATCH] efivars: Fix check for CONFIG_EFI_VARS_PSTORE_DEFAULT

linux-efi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH] efivars: Fix check for CONFIG_EFI_VARS_PSTORE_DEFAULT_DISABLE
@ 2013-03-22 19:56 Ben Hutchings
  2013-03-22 20:11 ` Paul Bolle
  2013-03-22 20:14 ` Matt Fleming
  0 siblings, 2 replies; 5+ messages in thread
From: Ben Hutchings @ 2013-03-22 19:56 UTC (permalink / raw)
  To: Matt Fleming
  Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA, Seth Forshee,
	stable-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 826 bytes --]

The 'CONFIG_' prefix is not implicit in IS_ENABLED().

Signed-off-by: Ben Hutchings <ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>
Cc: Seth Forshee <seth.forshee-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
---
 drivers/firmware/efivars.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index d64661f..7acafb8 100644
--- a/drivers/firmware/efivars.c
+++ b/drivers/firmware/efivars.c
@@ -104,7 +104,7 @@ MODULE_VERSION(EFIVARS_VERSION);
 #define GUID_LEN 36
 
 static bool efivars_pstore_disable =
-	IS_ENABLED(EFI_VARS_PSTORE_DEFAULT_DISABLE);
+	IS_ENABLED(CONFIG_EFI_VARS_PSTORE_DEFAULT_DISABLE);
 
 module_param_named(pstore_disable, efivars_pstore_disable, bool, 0644);
 


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] efivars: Fix check for CONFIG_EFI_VARS_PSTORE_DEFAULT_DISABLE
  2013-03-22 19:56 [PATCH] efivars: Fix check for CONFIG_EFI_VARS_PSTORE_DEFAULT_DISABLE Ben Hutchings
@ 2013-03-22 20:11 ` Paul Bolle
       [not found]   ` <1363983063.1390.186.camel-uMdlDhfIn7prKue/0VVhAg@public.gmane.org>
  2013-03-22 20:14 ` Matt Fleming
  1 sibling, 1 reply; 5+ messages in thread
From: Paul Bolle @ 2013-03-22 20:11 UTC (permalink / raw)
  To: Ben Hutchings; +Cc: Matt Fleming, linux-efi, Seth Forshee, stable

On Fri, 2013-03-22 at 19:56 +0000, Ben Hutchings wrote:
> The 'CONFIG_' prefix is not implicit in IS_ENABLED().

    $ git grep -n "\bIS_ENABLED(" | grep -v "(CONFIG_"
    arch/arm/mach-clps711x/board-autcpu12.c:161:	if (IS_ENABLED(MTD_NAND_GPIO) && IS_ENABLED(GPIO_GENERIC_PLATFORM)) {
    arch/arm64/mm/mmu.c:264:	bool page64k = IS_ENABLED(ARM64_64K_PAGES);
    [...]

Did you check these other three (potential) problems too?


Paul Bolle

^ permalink raw reply	[flat|nested] 5+ messages in thread

[parent not found: <1363983063.1390.186.camel-uMdlDhfIn7prKue/0VVhAg@public.gmane.org>]

* Re: [PATCH] efivars: Fix check for CONFIG_EFI_VARS_PSTORE_DEFAULT_DISABLE
       [not found]   ` <1363983063.1390.186.camel-uMdlDhfIn7prKue/0VVhAg@public.gmane.org>
@ 2013-03-22 20:18     ` Ben Hutchings
  2013-03-22 20:22       ` Paul Bolle
  0 siblings, 1 reply; 5+ messages in thread
From: Ben Hutchings @ 2013-03-22 20:18 UTC (permalink / raw)
  To: Paul Bolle
  Cc: Matt Fleming, linux-efi-u79uwXL29TY76Z2rM5mHXA, Seth Forshee,
	stable-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 686 bytes --]

On Fri, 2013-03-22 at 21:11 +0100, Paul Bolle wrote:
> On Fri, 2013-03-22 at 19:56 +0000, Ben Hutchings wrote:
> > The 'CONFIG_' prefix is not implicit in IS_ENABLED().
> 
>     $ git grep -n "\bIS_ENABLED(" | grep -v "(CONFIG_"
>     arch/arm/mach-clps711x/board-autcpu12.c:161:	if (IS_ENABLED(MTD_NAND_GPIO) && IS_ENABLED(GPIO_GENERIC_PLATFORM)) {
>     arch/arm64/mm/mmu.c:264:	bool page64k = IS_ENABLED(ARM64_64K_PAGES);
>     [...]
> 
> Did you check these other three (potential) problems too?

I found those too, but this one was slightly more urgent for me!

Ben.

-- 
Ben Hutchings
Make three consecutive correct guesses and you will be considered an expert.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] efivars: Fix check for CONFIG_EFI_VARS_PSTORE_DEFAULT_DISABLE
  2013-03-22 20:18     ` Ben Hutchings
@ 2013-03-22 20:22       ` Paul Bolle
  0 siblings, 0 replies; 5+ messages in thread
From: Paul Bolle @ 2013-03-22 20:22 UTC (permalink / raw)
  To: Ben Hutchings; +Cc: Matt Fleming, linux-efi, Seth Forshee, stable

On Fri, 2013-03-22 at 20:18 +0000, Ben Hutchings wrote:
> I found those too[...]!

Great! Would you mind CC-ing me if you find the time to fix these, if
that turns out to be necessary?


Paul Bolle

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] efivars: Fix check for CONFIG_EFI_VARS_PSTORE_DEFAULT_DISABLE
  2013-03-22 19:56 [PATCH] efivars: Fix check for CONFIG_EFI_VARS_PSTORE_DEFAULT_DISABLE Ben Hutchings
  2013-03-22 20:11 ` Paul Bolle
@ 2013-03-22 20:14 ` Matt Fleming
  1 sibling, 0 replies; 5+ messages in thread
From: Matt Fleming @ 2013-03-22 20:14 UTC (permalink / raw)
  To: Ben Hutchings; +Cc: linux-efi, Seth Forshee, stable

On 22/03/13 19:56, Ben Hutchings wrote:
> The 'CONFIG_' prefix is not implicit in IS_ENABLED().
> 
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> Cc: Seth Forshee <seth.forshee@canonical.com>
> Cc: <stable@vger.kernel.org>
> ---
>  drivers/firmware/efivars.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied. Thanks for catching this!

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-03-22 20:22 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-22 19:56 [PATCH] efivars: Fix check for CONFIG_EFI_VARS_PSTORE_DEFAULT_DISABLE Ben Hutchings
2013-03-22 20:11 ` Paul Bolle
     [not found]   ` <1363983063.1390.186.camel-uMdlDhfIn7prKue/0VVhAg@public.gmane.org>
2013-03-22 20:18     ` Ben Hutchings
2013-03-22 20:22       ` Paul Bolle
2013-03-22 20:14 ` Matt Fleming

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).