From: Matt Fleming <matt@console-pimps.org>
To: Daniel Vacek <neelx.g@gmail.com>
Cc: Matthew Garrett <mjg@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
matt.fleming@intel.com, linux-efi@vger.kernel.org,
ben@decadent.org.uk, linux-kernel@vger.kernel.org,
x86@kernel.org, stable@vger.kernel.org
Subject: Re: Patch "efi: Build EFI stub with EFI-appropriate options" has been added to the 3.6-stable tree
Date: Wed, 03 Apr 2013 11:28:11 +0100 [thread overview]
Message-ID: <515C043B.4070401@console-pimps.org> (raw)
In-Reply-To: <CAA7rmPFxzoOgcrYRetyx3hY-Y_cj0jzuY=sGAj-v2X59vCrrDg@mail.gmail.com>
On 30/03/13 10:04, Daniel Vacek wrote:
> On Sat, Mar 30, 2013 at 4:28 AM, Ben Hutchings <ben@decadent.org.uk> wrote:
>> Daniel, this is an obvious fix but I noticed it still hasn't been
>> applied. Please can you re-send with the proper Signed-off-by line?
>
> Resending patch. It got lost somewhere. Thanks for pushing Ben.
>
> From 53864fe932aa87be62f1c70944c386cff9bb9130 Mon Sep 17 00:00:00 2001
> From: Daniel Vacek <neelx.g@gmail.com>
> Date: Thu, 18 Oct 2012 22:06:26 +0200
> Subject: [PATCH] efi: fix typo in Makefile
>
> Fix a little typo.
>
> Signed-off-by: Daniel Vacek <neelx.g@gmail.com>
> Acked-by: Matthew Garrett <mjg@redhat.com>
> ---
> arch/x86/boot/compressed/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I applied this by hand. Your patch appears to be whitespace damaged. Also, I
expanded the commit message and turned it into,
efi: fix typo in Makefile
commit 9dead5bbb825 ("efi: Build EFI stub with EFI-appropriate options")
contains a typo which means that the efi_stub_$(BITS).o code is still not
compiled with -fshort-wchar and -mno-red-zone.
Fix it with s/KBUILD_CLFAGS/KBUILD_CFLAGS/
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-04-03 10:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <13511021101759@kroah.org>
[not found] ` <CAA7rmPF4oZjvwQ5LU1pJAydWhbwmCmzgUudUvQ5_YPpS_Rnjvg@mail.gmail.com>
[not found] ` <CAA7rmPF4oZjvwQ5LU1pJAydWhbwmCmzgUudUvQ5_YPpS_Rnjvg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-03-30 3:28 ` Patch "efi: Build EFI stub with EFI-appropriate options" has been added to the 3.6-stable tree Ben Hutchings
2013-03-30 10:04 ` Daniel Vacek
2013-04-03 10:28 ` Matt Fleming [this message]
[not found] ` <CAA7rmPE3qNmny0+pBpinCdFHEz2RYXWKTtzyWJ-jp-YDOkC7ow@mail.gmail.com>
2013-04-03 11:13 ` Daniel Vacek
[not found] ` <515C043B.4070401-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-04-08 9:32 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515C043B.4070401@console-pimps.org \
--to=matt@console-pimps.org \
--cc=ben@decadent.org.uk \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mjg@redhat.com \
--cc=neelx.g@gmail.com \
--cc=stable@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).