From: Lingzhu Xiang <lxiang@redhat.com>
To: Matthew Garrett <matthew.garrett@nebula.com>
Cc: matt.fleming@intel.com, linux-efi@vger.kernel.org,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH 3/3] efi: Distinguish between "remaining space" and actually used space
Date: Wed, 10 Apr 2013 14:02:52 +0800 [thread overview]
Message-ID: <5165008C.1000504@redhat.com> (raw)
In-Reply-To: <1365561717-12343-3-git-send-email-matthew.garrett@nebula.com>
On 04/10/2013 10:41 AM, Matthew Garrett wrote:
> + if (!storage_size || size > remaining_size ||
> + ((active_size + size + VAR_METADATA_SIZE > storage_size / 2) &&
> + (remaining_size - size - VAR_METADATA_SIZE < storage_size / 2)))
This could overflow.
(u64)32768 - (u64)32768 - VAR_METADATA_SIZE < (u64)65536 / 2 == false
next prev parent reply other threads:[~2013-04-10 6:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 2:41 [PATCH 1/3] efi: Determine how much space is used by boot services-only variables Matthew Garrett
2013-04-10 2:41 ` [PATCH 2/3] Revert "x86, efivars: firmware bug workarounds should be in platform code" Matthew Garrett
2013-04-10 17:46 ` [PATCH V4 1/3] efi: Determine how much space is used by boot services-only variables Matthew Garrett
[not found] ` <1365615967-27346-1-git-send-email-matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
2013-04-10 17:46 ` [PATCH V4 2/3] Revert "x86, efivars: firmware bug workarounds should be in platform code" Matthew Garrett
[not found] ` <1365615967-27346-2-git-send-email-matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
2013-04-11 13:24 ` Matt Fleming
2013-04-11 13:30 ` Matthew Garrett
2013-04-10 17:46 ` [PATCH V4 3/3] efi: Distinguish between "remaining space" and actually used space Matthew Garrett
2013-04-12 10:16 ` [PATCH V4 1/3] efi: Determine how much space is used by boot services-only variables Lingzhu Xiang
2013-04-12 10:22 ` Matt Fleming
2013-04-12 12:19 ` Lingzhu Xiang
2013-04-15 15:53 ` [PATCH V5 1/2] efi: Pass boot services variable info to runtime code Matthew Garrett
2013-04-15 15:53 ` [PATCH V5 2/2] efi: Distinguish between "remaining space" and actually used space Matthew Garrett
[not found] ` <1365561717-12343-1-git-send-email-matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
2013-04-10 2:41 ` [PATCH 3/3] " Matthew Garrett
2013-04-10 6:02 ` Lingzhu Xiang [this message]
2013-04-15 20:09 ` Fix UEFI variable paranoia Matthew Garrett
2013-04-15 20:09 ` [PATCH V6 1/3] Move utf16 functions to kernel core and rename Matthew Garrett
2013-04-15 20:09 ` [PATCH V6 2/3] efi: Pass boot services variable info to runtime code Matthew Garrett
[not found] ` <1366056587-24414-3-git-send-email-matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
2013-04-22 15:03 ` Paul Bolle
2013-04-15 20:09 ` [PATCH V6 3/3] efi: Distinguish between "remaining space" and actually used space Matthew Garrett
[not found] ` <1366056587-24414-4-git-send-email-matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
2013-04-16 14:31 ` [PATCH 1/2] x86/Kconfig: Make EFI select UCS2_STRING Sergey Vlasov
[not found] ` <1366122669-20898-1-git-send-email-vsu-u2l5PoMzF/Uox3rIn2DAYQ@public.gmane.org>
2013-04-16 14:31 ` [PATCH 2/2] efi: Export efi_query_variable_store() for efivars.ko Sergey Vlasov
[not found] ` <1366122669-20898-2-git-send-email-vsu-u2l5PoMzF/Uox3rIn2DAYQ@public.gmane.org>
2013-04-16 16:39 ` Matt Fleming
2013-04-16 16:39 ` [PATCH 1/2] x86/Kconfig: Make EFI select UCS2_STRING Matt Fleming
2013-04-17 10:49 ` [PATCH V6 3/3] efi: Distinguish between "remaining space" and actually used space Lingzhu Xiang
2013-04-24 10:08 ` joeyli
[not found] ` <1366798111.23707.293.camel-ONCj+Eqt86TasUa73XJKwA@public.gmane.org>
2013-04-24 10:14 ` Matthew Garrett
[not found] ` <1366798497.13667.25.camel-+5W/JHIUVxg@public.gmane.org>
2013-04-24 10:59 ` joeyli
[not found] ` <1366801173.23707.323.camel-ONCj+Eqt86TasUa73XJKwA@public.gmane.org>
2013-04-24 11:57 ` Matthew Garrett
[not found] ` <1366804640.13667.27.camel-+5W/JHIUVxg@public.gmane.org>
2013-04-24 13:23 ` joeyli
[not found] ` <1366056587-24414-1-git-send-email-matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
2013-04-16 10:15 ` Fix UEFI variable paranoia Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5165008C.1000504@redhat.com \
--to=lxiang@redhat.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=matthew.garrett@nebula.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).