From: Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
To: Mike Waychison <mikew-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Matt Fleming
<matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Tom Gundersen <teg-B22kvLQNl6c@public.gmane.org>
Subject: Re: [PATCH 2/6] efivars: Keep a private global pointer to efivars
Date: Thu, 11 Apr 2013 14:10:07 +0100 [thread overview]
Message-ID: <5166B62F.4000206@console-pimps.org> (raw)
In-Reply-To: <CAGTjWtAhLQVrpJSUWU=HgxuBkcjfPj_o4hN9o-ELK1g89eGA_Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 09/04/13 23:07, Mike Waychison wrote:
>> +config EFI_VARS_GENERIC_OPS
>> + bool
>> + depends on EFI
>> + depends on !GOOGLE_SMI
>> + default y
>> +
>
> So while we have no need to support both the gsmi and real efi
> entrypoints on any given machine, we still need to be able to support
> the operation of both from the same kernel build. How do you feel
> about removing this bit and leaving it such that efivars_init
> continues to register the "generic" efivars regardless of
> CONFIG_GOOGLE_SMI? The rest of the patch seems fine to me.
OK sure, we can do that. Thanks for the review.
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-04-11 13:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 12:18 [PATCH 0/6] Chainsaw efivars.c Matt Fleming
2013-04-04 12:18 ` [PATCH 4/6] efivars: Move pstore code into the new EFI directory Matt Fleming
2013-04-04 12:18 ` [PATCH 5/6] efivarfs: Move to fs/efivarfs Matt Fleming
2013-04-04 12:18 ` [PATCH 6/6] efi: split efisubsystem from efivars Matt Fleming
[not found] ` <1365077935-6859-1-git-send-email-matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-04-04 12:18 ` [PATCH 1/6] efi: move utf16 string functions to efi.h Matt Fleming
[not found] ` <1365077935-6859-2-git-send-email-matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-04-09 22:00 ` Mike Waychison
[not found] ` <CAGTjWtCFSxJMKf=Xp+5MKLSb3qH4YpWVYYmUb6fkjwctMc1bDQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-04-10 11:18 ` David Woodhouse
2013-04-04 12:18 ` [PATCH 2/6] efivars: Keep a private global pointer to efivars Matt Fleming
[not found] ` <1365077935-6859-3-git-send-email-matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-04-09 22:07 ` Mike Waychison
[not found] ` <CAGTjWtAhLQVrpJSUWU=HgxuBkcjfPj_o4hN9o-ELK1g89eGA_Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-04-11 13:10 ` Matt Fleming [this message]
2013-04-04 12:18 ` [PATCH 3/6] efivars: efivar_entry API Matt Fleming
[not found] ` <1365077935-6859-4-git-send-email-matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-04-10 15:25 ` Seiji Aguchi
[not found] ` <A5ED84D3BB3A384992CBB9C77DEDA4D41AF8CFEE-ohthHghroY0jroPwUH3sq+6wyyQG6/Uh@public.gmane.org>
2013-04-11 13:34 ` Matt Fleming
2013-04-09 16:25 ` [PATCH 0/6] Chainsaw efivars.c H. Peter Anvin
[not found] ` <516440F5.7040904-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2013-04-09 16:50 ` Matt Fleming
-- strict thread matches above, loose matches on Subject: below --
2013-04-17 12:47 [PATCH v3 " Matt Fleming
2013-04-17 12:47 ` [PATCH 2/6] efivars: Keep a private global pointer to efivars Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5166B62F.4000206@console-pimps.org \
--to=matt-hnk1s37rvnbexh+ff434mdi2o/jbrioy@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=mikew-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=teg-B22kvLQNl6c@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).