From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH v2 0/6] Chainsaw efivars.c Date: Wed, 17 Apr 2013 13:48:17 +0100 Message-ID: <516E9A11.1040404@console-pimps.org> References: <1366148520-29954-1-git-send-email-matt@console-pimps.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Tom Gundersen Cc: "linux-efi@vger.kernel.org" , LKML , "H. Peter Anvin" , Matt Fleming List-Id: linux-efi@vger.kernel.org On 04/17/2013 01:30 AM, Tom Gundersen wrote: > Hi Matt, > > On Tue, Apr 16, 2013 at 11:41 PM, Matt Fleming wrote: >> This patch series introduces the new efivar_entry API, and splits out the major >> parts of efivars.c into new files. In particular, having the efivarfs code >> under fs/ allows building an efivarfs.ko module, which means mount(8) can >> automatically load it. >> >> The remaining EFI code is repositioned under drivers/firmware/efi/. > > These all look good to me, so feel free to add my Reviewed-by. > > Tested on top of 3.9-rc7, with everything built as modules. Everything > works as intended: systemd correctly detects it is on an EFI system, > so mounts efivarfs, which auto-loads the required modules. > > Thanks a lot! Thanks for reviewing and testing! I've added your Reviewed-by and Tested-by tags to all 5 patches (but not the one you authored). I found a bug in PATCH 3, so I've sent out a v3 of the series. Peter, I've pulled these 6 patches into the 'chainsaw' branch in the EFI repo. I think the prudent thing to do (as you previously suggested) is to merge that branch into tip as a separate topic branch, just in case we need to drop it before the merge window opens. -- Matt Fleming, Intel Open Source Technology Center