From: "H. Peter Anvin" <hpa@zytor.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Roy Franz <roy.franz@linaro.org>,
linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
matt.fleming@intel.com, msalter@redhat.com, patches@linaro.org
Subject: Re: [PATCH] Remove redundant and incorrect memset()
Date: Fri, 04 Oct 2013 10:38:07 -0700 [thread overview]
Message-ID: <524EFCFF.3000003@zytor.com> (raw)
In-Reply-To: <20131004173310.GA15689@gmail.com>
On 10/04/2013 10:33 AM, Ingo Molnar wrote:
>
> * Roy Franz <roy.franz@linaro.org> wrote:
>
>> Remove a redundant memset() call from efi_relocate_kernel() that
>> was clearing memory that would be used by BSS in non-compressed
>> images loaded with this function. This clear was redundant with
>> the clearing done in the image itself, and also implemented incorrectly
>> with a 0 length.
>>
>> Signed-off-by: Roy Franz <roy.franz@linaro.org>
>> Acked-by: Mark Salter <msalter@redhat.com>
>
> Note the title:
>
> [PATCH] Remove redundant and incorrect memset()
>
> if it's both redundant *and* incorrect then the other memset() must be
> incorrect too and must be removed as well ;-)
>
> I suspect you wanted the title to say:
>
> [PATCH] Remove redundant memset()
>
And more importantly:
[PATCH] boot,efi: Remove redundant memset()
next prev parent reply other threads:[~2013-10-04 17:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20131003131054.GB27835@gmail.com>
2013-10-04 16:02 ` [PATCH] Remove redundant and incorrect memset() Roy Franz
2013-10-04 17:33 ` Ingo Molnar
2013-10-04 17:38 ` H. Peter Anvin [this message]
[not found] ` <CAFECyb_ddUU8p87iOZ43PxW3h-E5cJ-0BUEr9i4Z-VrUez6=Jw@mail.gmail.com>
2013-10-04 17:39 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524EFCFF.3000003@zytor.com \
--to=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@kernel.org \
--cc=msalter@redhat.com \
--cc=patches@linaro.org \
--cc=roy.franz@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).