linux-efi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
To: Matthew Garrett
	<matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>,
	matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	stable-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH] UEFI: Don't use UEFI time services on 32-bit
Date: Fri, 29 Nov 2013 17:45:08 -0800	[thread overview]
Message-ID: <52994324.4000404@zytor.com> (raw)
In-Reply-To: <1385754283-2464-1-git-send-email-matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>

On 11/29/2013 11:44 AM, Matthew Garrett wrote:
> UEFI time services are often broken once we're in virtual mode. We were
> already refusing to use them on 64-bit systems, but it turns out that
> they're also broken on some 32-bit firmware, including the Dell Venue.
> Disable them for now, we can revisit once we have the 1:1 mappings code
> incorporated.
> 
> Signed-off-by: Matthew Garrett <matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
> Cc: stable-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
> ---
>  arch/x86/platform/efi/efi.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
> index 92c0234..cceb813 100644
> --- a/arch/x86/platform/efi/efi.c
> +++ b/arch/x86/platform/efi/efi.c
> @@ -690,13 +690,6 @@ void __init efi_init(void)
>  
>  	set_bit(EFI_MEMMAP, &x86_efi_facility);
>  
> -#ifdef CONFIG_X86_32
> -	if (efi_is_native()) {
> -		x86_platform.get_wallclock = efi_get_time;
> -		x86_platform.set_wallclock = efi_set_rtc_mmss;
> -	}
> -#endif
> -

Does the Dell Venue have either an ACPI TAD or one of the PNP0B0x
devices exposed?

	-hpa

  parent reply	other threads:[~2013-11-30  1:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-29 19:44 [PATCH] UEFI: Don't use UEFI time services on 32-bit Matthew Garrett
     [not found] ` <1385754283-2464-1-git-send-email-matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
2013-11-29 22:04   ` joeyli
     [not found]     ` <1385762647.3539.4.camel-ONCj+Eqt86TasUa73XJKwA@public.gmane.org>
2013-11-29 22:30       ` Borislav Petkov
2013-12-05 10:56       ` Matt Fleming
2013-11-30  1:45   ` H. Peter Anvin [this message]
     [not found]     ` <52994324.4000404-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2013-12-10 22:54       ` H. Peter Anvin
     [not found]         ` <52A79B9A.7080004-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2013-12-10 22:58           ` Matthew Garrett
2013-12-10 23:20             ` H. Peter Anvin
     [not found]               ` <52A7A1B0.7050903-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2013-12-10 23:24                 ` Matthew Garrett
2013-12-10 23:51                   ` H. Peter Anvin
     [not found]                     ` <52A7A915.1070701-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2013-12-11  0:20                       ` joeyli
     [not found]                         ` <1386721257.3539.1717.camel-ONCj+Eqt86TasUa73XJKwA@public.gmane.org>
2013-12-11  4:00                           ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52994324.4000404@zytor.com \
    --to=hpa-ymnouzjc4hwavxtiumwx3w@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org \
    --cc=stable-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).