From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH] ACPI / init: Run acpi_early_init() before timekeeping_init() Date: Wed, 15 Jan 2014 04:16:59 -0800 Message-ID: <52D67C3B.4050503@zytor.com> References: <1389770748-32698-1-git-send-email-jlee@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1389770748-32698-1-git-send-email-jlee@suse.com> Sender: linux-acpi-owner@vger.kernel.org To: "Lee, Chun-Yi" , "Rafael J. Wysocki" , Alessandro Zummo , Matt Fleming , Matthew Garrett Cc: Elliott@hp.com, samer.el-haj-mahmoud@hp.com, Oliver Neukum , werner@suse.com, trenn@suse.de, JBeulich@suse.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, x86@kernel.org, "linux-efi@vger.kernel.org" , linux-acpi@vger.kernel.org, "Lee, Chun-Yi" , Borislav Petkov List-Id: linux-efi@vger.kernel.org Rafael, you want to take this one? On 01/14/2014 11:25 PM, Lee, Chun-Yi wrote: > This is a variant patch from Rafael J. Wysocki's > ACPI / init: Run acpi_early_init() before efi_enter_virtual_mode() > > According to Matt Fleming, if acpi_early_init() was executed before > efi_enter_virtual_mode(), the EFI initialization could benefit from > it, so Rafael's patch makes that happen. > > And, we want accessing ACPI TAD device to set system clock, so move > acpi_early_init() before timekeeping_init(). This final position is > also before efi_enter_virtual_mode(). > > v2: > Move acpi_early_init() before timekeeping_init() to prepare setting > system clock with ACPI TAD. > > v1: > Rafael J. Wysocki > ACPI / init: Run acpi_early_init() before efi_enter_virtual_mode() > > Cc: Rafael J. Wysocki > Cc: Matt Fleming > Cc: H. Peter Anvin > Cc: Borislav Petkov > Cc: Matthew Garrett > Tested-by: Toshi Kani > Signed-off-by: Lee, Chun-Yi > --- > init/main.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/init/main.c b/init/main.c > index febc511..b6d93c8 100644 > --- a/init/main.c > +++ b/init/main.c > @@ -565,6 +565,7 @@ asmlinkage void __init start_kernel(void) > init_timers(); > hrtimers_init(); > softirq_init(); > + acpi_early_init(); > timekeeping_init(); > time_init(); > sched_clock_postinit(); > @@ -641,7 +642,6 @@ asmlinkage void __init start_kernel(void) > > check_bugs(); > > - acpi_early_init(); /* before LAPIC and SMP init */ > sfi_init_late(); > > if (efi_enabled(EFI_RUNTIME_SERVICES)) { >