From: Michael Brown <mbrown-OViyBiuKJBuK421+ScFKDQ@public.gmane.org>
To: Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3] efi: Request desired alignment via the PE/COFF headers
Date: Fri, 11 Jul 2014 16:16:30 +0100 [thread overview]
Message-ID: <53BFFFCE.5040002@fensystems.co.uk> (raw)
In-Reply-To: <20140711074117.GE5952-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
On 11/07/14 08:41, Matt Fleming wrote:
>> i.e. that the memory used for alignment was not explicitly
>> allocated. If the EFI boot stub instead allocates space for the
>> aligned kernel using AllocatePages() (and allocates enough space for
>> the whole of init_size), then the problem I described does not
>> exist.
>
> Right, this shouldn't be a problem because we do in fact allocate space
> using the EFI boottime services in efi_relocate_kernel(), taking the
> alignment into account, and then perform the kernel image copy.
>
> I still think your change makes sense, I'm just inclined to delete the
> paragraph referring to the corruption bug (which we've established
> doesn't exist).
Since the patch itself is so trivial, I'm happy for you to commit it as
your own, with whatever commit message you think makes most sense.
Michael
next prev parent reply other threads:[~2014-07-11 15:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 15:59 [PATCH v3] efi: Request desired alignment via the PE/COFF headers Michael Brown
[not found] ` <1405007963-520-1-git-send-email-mbrown-OViyBiuKJBuK421+ScFKDQ@public.gmane.org>
2014-07-10 20:36 ` Matt Fleming
[not found] ` <20140710203633.GC5952-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-07-11 0:18 ` Michael Brown
[not found] ` <53BF2D63.60808-OViyBiuKJBuK421+ScFKDQ@public.gmane.org>
2014-07-11 7:41 ` Matt Fleming
[not found] ` <20140711074117.GE5952-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-07-11 15:16 ` Michael Brown [this message]
[not found] ` <53BFFFCE.5040002-OViyBiuKJBuK421+ScFKDQ@public.gmane.org>
2014-07-14 13:10 ` Matt Fleming
[not found] ` <20140714131042.GJ5952-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-07-14 13:28 ` Michael Brown
2015-06-15 21:43 ` Linn Crosetto
[not found] ` <loom.20150615T232724-11-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>
2015-06-16 16:19 ` Michael Brown
[not found] ` <55804C91.4030000-OViyBiuKJBuK421+ScFKDQ@public.gmane.org>
2015-06-16 17:37 ` Linn Crosetto
[not found] ` <20150616173725.GE13153-QpTgeCMhooRo/CpIj0byZw@public.gmane.org>
2015-06-18 22:02 ` Matt Fleming
[not found] ` <20150618220241.GA2776-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-06-18 22:27 ` Michael Brown
[not found] ` <558345EB.8010408-OViyBiuKJBuK421+ScFKDQ@public.gmane.org>
2015-06-19 12:21 ` Matt Fleming
[not found] ` <20150619122147.GC2776-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-06-19 12:25 ` Michael Brown
[not found] ` <55840A3B.3000400-OViyBiuKJBuK421+ScFKDQ@public.gmane.org>
2015-07-15 14:11 ` Matt Fleming
[not found] ` <20150715141119.GA6955-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-07-15 16:56 ` Linn Crosetto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BFFFCE.5040002@fensystems.co.uk \
--to=mbrown-oviybiukjbuk421+scfkdq@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).