From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [REGRESSION] "efi: efistub: Convert into static library" and preparation patches Date: Wed, 03 Sep 2014 14:28:39 -0700 Message-ID: <54078807.7090408@zytor.com> References: <5405E186.2080406@canonical.com> <20140902192941.GB3001@console-pimps.org> <5406D0DB.90401@canonical.com> <54073409.6030004@canonical.com> <20140903175948.GH3001@console-pimps.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ard Biesheuvel , Matt Fleming Cc: Maarten Lankhorst , Ulf Winkelvos , Matt Fleming , LKML , "x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Seth Forshee , Matthew Garrett List-Id: linux-efi@vger.kernel.org On 09/03/2014 12:57 PM, Ard Biesheuvel wrote: > > I guess that is likely to work, I just wasn't aware it existed :-) > I think adding another visibility(hidden) attribute or 2 would > complete eliminate the need for GOT fixups, but I guess that is more > sensitive to compiler versions being recent enough etc. > The attached (build tested only) patch eliminates all GOT relocations > under boot/compressed for a 64-bit EFI stub build. > This would be better. There is no reason to have a GOT in what is inherently a monolithic binary. Unfortunately -fvisibility=hidden doesn't seem to be enough. -hpa