From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Jonathan Zhixiong" Subject: Re: [PATCH V6 1/4] efi: x86: rearrange efi_mem_attributes() Date: Wed, 22 Jul 2015 10:21:27 -0700 Message-ID: <55AFD117.90801@codeaurora.org> References: <1437438759-3686-1-git-send-email-zjzhang@codeaurora.org> <1437438759-3686-2-git-send-email-zjzhang@codeaurora.org> <20150722111106.GC2734@codeblueprint.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150722111106.GC2734-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matt Fleming Cc: Matt Fleming , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, ying.huang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, al.stone-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org, rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linaro-acpi-cunTk1MwBs8s++Sfvej+rw@public.gmane.org List-Id: linux-efi@vger.kernel.org Appreciate Matt for your ack. On 7/22/2015 4:11 AM, Matt Fleming wrote: > On Mon, 20 Jul, at 05:32:36PM, Jonathan (Zhixiong) Zhang wrote: >> From: "Jonathan (Zhixiong) Zhang" >> >> x86 and ia64 implement efi_mem_attributes() differently. This >> function needs to be available for other arch (such as arm64) >> as well, such as for the purpose of ACPI/APEI. >> >> ia64 efi does not setup memmap variable and does not set >> EFI_MEMMAP flag, so it needs to have its unique implementation >> of efi_mem_attributes(). >> >> Move efi_mem_attributes() implementation from x86 to efi, and >> declare it with __weak. It is recommended that other archs >> should not override the default implementation. >> >> Signed-off-by: Jonathan (Zhixiong) Zhang >> --- >> arch/x86/platform/efi/efi.c | 18 ------------------ >> drivers/firmware/efi/efi.c | 31 +++++++++++++++++++++++++++++++ >> 2 files changed, 31 insertions(+), 18 deletions(-) > > Reviewed-by: Matt Fleming > -- Jonathan (Zhixiong) Zhang The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project