From mboxrd@z Thu Jan 1 00:00:00 1970 From: fupan Subject: Re: [PATCH 3.10 ~ 3.14] efi: fix the efi 32bit boot failed problem Date: Fri, 31 Jul 2015 09:22:33 +0800 Message-ID: <55BACDD9.6020505@windriver.com> References: <1438078879-24705-1-git-send-email-fupan.li@windriver.com> <20150730150428.GJ2725@codeblueprint.co.uk> <20150730163102.GA19943@kroah.com> <20150730164544.GL2725@codeblueprint.co.uk> <20150730165943.GD5515@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150730165943.GD5515-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Greg KH , Matt Fleming Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, fupanli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Luis Henriques , stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-efi@vger.kernel.org On 07/31/2015 12:59 AM, Greg KH wrote: > On Thu, Jul 30, 2015 at 05:45:44PM +0100, Matt Fleming wrote: >> On Thu, 30 Jul, at 09:31:02AM, Greg KH wrote: >>> Why isn't this an issue in newer kernel releases? Did this already get >>> fixed by some other patch? If so, why can't we just take that patch? >>> If not, why not? >> >> The commit 35d5134b7d5a ("x86/efi: Correct EFI boot stub use of >> code32_start") only exists in the stable trees in that form because >> there was quite a lot of churn in that area in Linus tree that didn't >> get backported. >> >> So the code in Linus' tree never looked like the code in the stable does >> right now. >> >>> I _REALLY_ don't like taking patches that are not already in Linus's >>> tree, as it almost always turns out to be the wrong solution. >> Yeah, I think this issue verifies that. > Ugh, what a mess. Ok, if you get something that works and is in a > format that I can apply it, please resend it properly so that we can do > so. Hi, Matt Will you take care of this patch or I send a V2? Thanks! Fupan > > thanks, > > greg k-h > >