From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Jonathan Zhixiong" Subject: Re: [PATCH V2 1/2] arm64: apei: implement arch_apei_get_mem_attributes() Date: Mon, 17 Aug 2015 14:09:58 -0700 Message-ID: <55D24DA6.3080105@codeaurora.org> References: <1439591850-29002-1-git-send-email-zjzhang@codeaurora.org> <20150817130553.GA3233@codeblueprint.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150817130553.GA3233-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matt Fleming Cc: Ingo Molnar , Thomas Gleixner , "H . Peter Anvin" , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Matt Fleming , Ard Biesheuvel , Catalin Marinas , Hanjun Guo , Will Deacon List-Id: linux-efi@vger.kernel.org On 8/17/2015 6:05 AM, Matt Fleming wrote: > On Fri, 14 Aug, at 03:37:29PM, Jonathan (Zhixiong) Zhang wrote: >> From: "Jonathan (Zhixiong) Zhang" >> >> Table 8 of UEFI 2.5 section 2.3.6.1 defines mappings from EFI >> memory types to MAIR attribute encodings for arm64. >> >> If the physical address has memory attributes defined by EFI >> memmap as EFI_MEMORY_[UC|WC|WT], return approprate page protection >> type according to the UEFI spec. Otherwise, return PAGE_KERNEL. >> >> Reviewed-by: Catalin Marinas >> Acked-by: Hanjun Guo >> Signed-off-by: Jonathan (Zhixiong) Zhang >> Cc: Ingo Molnar >> Cc: Matt Fleming >> Cc: Hanjun Guo >> Cc: Will Deacon >> --- >> V2: Changed arm64's implementation of arch_apei_get_mem_attributes() >> from inline function to out of line function, based on Ingo's >> feedback. >> >> arch/arm64/include/asm/acpi.h | 5 +++++ >> arch/arm64/kernel/acpi.c | 29 +++++++++++++++++++++++++++++ >> 2 files changed, 34 insertions(+) >> > > Looks fine to me, though it appears to be missing Ard's Reviewed-by > tag (the only change from the previous version is that it's no longer > inline). > > Reviewed-by: Matt Fleming Thanks. Will add both Reviewed-by. > > Ingo, are you going to pick up this patch series and apply it directly > to tip if you're OK with this version? > -- Jonathan (Zhixiong) Zhang The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project