From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH] arm64: efi: make sure vmlinux load address aligned on 2MBytes Date: Tue, 27 Oct 2015 21:13:22 -0500 Message-ID: <56302F42.4040408@codeaurora.org> References: <1445981041-8774-1-git-send-email-timur@codeaurora.org> <56302E7C.7000605@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ard Biesheuvel Cc: Mark Rutland , Mark Salter , "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Will Deacon , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Matt Fleming , Shanker Donthineni , Mark Langsdorf , Jon Masters List-Id: linux-efi@vger.kernel.org Ard Biesheuvel wrote: > No. I screwed up the patch since the trailing ) should not be there, > but we do need to round first, and only then add the offset. But if the offset is not a multiple of 2MB, won't the address passed to allocate_pages be unaligned? I'll test your patch on our system, but I thought the problem was that the allocated address must be aligned. -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation.