From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Austin S. Hemmelgarn" Subject: Re: [PATCH] block: partitions: efi: Always check for alternative GPT at end of drive Date: Tue, 26 Apr 2016 15:27:13 -0400 Message-ID: <571FC111.7020700@gmail.com> References: <1461632806-5946-1-git-send-email-jwerner@chromium.org> <571F7D6D.8020209@gmail.com> <20160426181018.GA16601@linux-uzut.site> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160426181018.GA16601-95RKjC4jbl+7r5TWoziOLQ@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Davidlohr Bueso Cc: Julius Werner , linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Gwendal Grignou , Doug Anderson , Karel Zak List-Id: linux-efi@vger.kernel.org On 2016-04-26 14:10, Davidlohr Bueso wrote: > On Tue, 26 Apr 2016, Austin S. Hemmelgarn wrote: > >> At the absolute minimum, we should be logging (at least at a warning >> level) that we had to fall back the the backup GPT. If somebody is >> dealing with a disk that had a torn write to the primary GPT, that's >> one thing, but this could also be caused by any number of other >> problems (hardware issues, malicious intent, etc), and we need to log >> that we detected corrupted data. > > We already complain about corrupted primary gpt (at a warn level), and > there's also plenty of verbosity about differences between primary and > backup (see compare_gpts()), or are you referring to something else? Ah, you're right, somehow I had missed this.