From mboxrd@z Thu Jan 1 00:00:00 1970 From: Prarit Bhargava Subject: Re: ESRT failures ... was Re: [PATCH 04/11] efi: Add efi_memmap_init_late() for permanent EFI memmap Date: Mon, 25 Jul 2016 11:38:49 -0400 Message-ID: <57963289.2090805@redhat.com> References: <57867F32.8040001@redhat.com> <20160721121136.GF26504@codeblueprint.co.uk> <5790DFD0.4020806@redhat.com> <20160722131101.GJ26504@codeblueprint.co.uk> <57922028.7070103@redhat.com> <20160725144431.GA31759@codeblueprint.co.uk> <57962C23.5090705@redhat.com> <20160725151344.GB31759@codeblueprint.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160725151344.GB31759-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matt Fleming Cc: Lenny Szubowicz , Peter Jones , linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ard Biesheuvel List-Id: linux-efi@vger.kernel.org On 07/25/2016 11:13 AM, Matt Fleming wrote: > On Mon, 25 Jul, at 11:11:31AM, Prarit Bhargava wrote: >> >> >> On 07/25/2016 10:44 AM, Matt Fleming wrote: >>> On Fri, 22 Jul, at 09:31:20AM, Prarit Bhargava wrote: >>>> >>>> Hmm ... maybe just a Dell specific quirk? >>> >>> Quirks are best avoided at all costs, platform-specific quirks doubly >>> so because there are just so many in the EFI arena that maintaining >>> them all would be a nightmare. >>> >>> Where possible we adopt a "most buggy implementation" approach to >>> compatibility, as a least common denominator. >>> >>> Could you try this patch out? It's not a final version, but I'd just >>> like to see if anything else explodes when we start returning reserved >>> regions. >>> >>> --- >>> >>> diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c >>> index 05509f3aaee8..9857796c4cd4 100644 >>> --- a/drivers/firmware/efi/efi.c >>> +++ b/drivers/firmware/efi/efi.c >>> @@ -299,7 +299,8 @@ int __init efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md) >>> >>> if (!(md->attribute & EFI_MEMORY_RUNTIME) && >>> md->type != EFI_BOOT_SERVICES_DATA && >>> - md->type != EFI_RUNTIME_SERVICES_DATA) { >>> + md->type != EFI_RUNTIME_SERVICES_DATA && >>> + md->type != EFI_RESERVED_TYPE) { >> >> I had tried this fix earlier FWIW and it causes the boot to hang. > > Do you know where it hangs? earlyprintk=efi might shed some light on > that if you don't have a serial console setup. > Nope, nothing else is displayed with "earlyprintk=efi" as a kernel parameter (I already had that as a kernel parameter). P.