Linux EFI development
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Ira Weiny <ira.weiny@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Jonathan Cameron <jonathan.cameron@huawei.com>,
	Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
Cc: Yazen Ghannam <yazen.ghannam@amd.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Dave Jiang <dave.jiang@intel.com>,
	Alison Schofield <alison.schofield@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	"Ard Biesheuvel" <ardb@kernel.org>, <linux-efi@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
	Ira Weiny <ira.weiny@intel.com>
Subject: RE: [PATCH RFC v2 3/3] cxl/memdev: Register for and process CPER events
Date: Thu, 26 Oct 2023 15:56:10 -0700	[thread overview]
Message-ID: <653aee8ad2717_780ef29418@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <20230601-cxl-cper-v2-3-314d9c36ab02@intel.com>

Ira Weiny wrote:
> If the firmware has configured CXL event support to be firmware first
> the OS can process those events through CPER records.  Matching memory
> devices to the CPER records can be done via the serial number which is
> part of the CPER record header.
> 
> Detect firmware first, register a notifier callback for each memdev, and
> trace events when they match a device registered.
> 
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> 
[..]

The changes requested in patch2 cover all of the comments I currently
have on this patch, just one more cleanup below:

> +#define CXL_EVENT_HDR_FLAGS_REC_SEVERITY GENMASK(1, 0)
> +int cxl_cper_event_call(struct notifier_block *nb, unsigned long action, void *data)
> +{
> +	struct cxl_cper_notifier_data *nd = data;
> +	struct cxl_event_record_raw record = (struct cxl_event_record_raw) {
> +		.hdr.id = UUID_INIT(0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0),
> +	};

Just do:

	struct cxl_event_record_raw record = { 0 };

...and the compiler will take care of the rest as initializing any field
automatically initializes everything else to zero.

  reply	other threads:[~2023-10-26 22:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-26 18:21 [PATCH RFC v2 0/3] efi/cxl-cper: Report CPER CXL component events through trace events Ira Weiny
2023-10-26 18:21 ` [PATCH RFC v2 1/3] cxl/trace: Remove uuid from event trace known events Ira Weiny
2023-10-26 20:55   ` Dan Williams
2023-10-30 16:58   ` Davidlohr Bueso
2023-10-26 18:21 ` [PATCH RFC v2 2/3] firmware/efi: Process CXL Component Events Ira Weiny
2023-10-26 21:02   ` Dan Williams
2023-10-31 16:46     ` Ira Weiny
2023-10-26 18:21 ` [PATCH RFC v2 3/3] cxl/memdev: Register for and process CPER events Ira Weiny
2023-10-26 22:56   ` Dan Williams [this message]
2023-10-31 17:13     ` Ira Weiny
2023-11-01 17:35       ` Jonathan Cameron
2023-10-30 21:03   ` Smita Koralahalli
2023-10-30 22:02     ` Dan Williams
2023-11-01  3:35     ` Ira Weiny
2023-11-01 21:59       ` Ira Weiny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=653aee8ad2717_780ef29418@dwillia2-xfh.jf.intel.com.notmuch \
    --to=dan.j.williams@intel.com \
    --cc=Smita.KoralahalliChannabasappa@amd.com \
    --cc=alison.schofield@intel.com \
    --cc=ardb@kernel.org \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=ira.weiny@intel.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vishal.l.verma@intel.com \
    --cc=yazen.ghannam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox